From 690de6a891d6f5b784ee221a4d8991a71ce5d223 Mon Sep 17 00:00:00 2001 From: David Wu Date: Tue, 12 Sep 2023 23:18:59 +0800 Subject: [PATCH] mb/google/brask/var/kuldax: Add fw_config probe for USB Hub Kuldax-refresh use USB Hub, add fw_config probe for USB Hub. BUG=b:275335023 BRANCH=brya TEST=Built and check firmware log. Change-Id: Ib983ca527a891718f317336597faad66d076247f Signed-off-by: David Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/77858 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/brya/Kconfig.name | 1 + .../brya/variants/kuldax/overridetree.cb | 26 +++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 73d30ff121..6ed217f5a5 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -173,6 +173,7 @@ config BOARD_GOOGLE_KULDAX select BOARD_GOOGLE_BASEBOARD_BRASK select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_GENESYSLOGIC_GL9755 + select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG select INTEL_GMA_HAVE_VBT select SOC_INTEL_RAPTORLAKE diff --git a/src/mainboard/google/brya/variants/kuldax/overridetree.cb b/src/mainboard/google/brya/variants/kuldax/overridetree.cb index ee46529dc6..a6adecfcf5 100644 --- a/src/mainboard/google/brya/variants/kuldax/overridetree.cb +++ b/src/mainboard/google/brya/variants/kuldax/overridetree.cb @@ -13,6 +13,10 @@ fw_config option TC_USB4 0 option TC_USB3 1 end + field USB_HUB 32 + option HUB_ABSENT 0 + option HUB_PRESENT 1 + end end chip soc/intel/alderlake @@ -281,7 +285,16 @@ chip soc/intel/alderlake register "type" = "UPC_TYPE_A" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(FRONT, RIGHT, ACPI_PLD_GROUP(1, 2))" - device ref usb2_port9 on end + device ref usb2_port9 on + probe USB_HUB HUB_ABSENT + end + end + chip drivers/usb/acpi + register "desc" = ""USB2 Hub for Type-A Port A0/A4/A5 (MLB)"" + register "type" = "UPC_TYPE_INTERNAL" + device ref usb2_port9 on + probe USB_HUB HUB_PRESENT + end end chip drivers/usb/acpi register "desc" = ""USB2 Bluetooth"" @@ -295,7 +308,16 @@ chip soc/intel/alderlake register "type" = "UPC_TYPE_USB3_A" register "use_custom_pld" = "true" register "custom_pld" = "ACPI_PLD_TYPE_A(FRONT, RIGHT, ACPI_PLD_GROUP(1, 2))" - device ref usb3_port1 on end + device ref usb3_port1 on + probe USB_HUB HUB_ABSENT + end + end + chip drivers/usb/acpi + register "desc" = ""USB3 Hub for Type-A Port A0/A4/A5 (MLB)"" + register "type" = "UPC_TYPE_INTERNAL" + device ref usb3_port1 on + probe USB_HUB HUB_PRESENT + end end chip drivers/usb/acpi register "desc" = ""USB3 Type-A Port A1 (MLB)""