From 691ff08e27b9f79e5178a0c3e6c51f9327f207d5 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sun, 3 Aug 2014 19:42:02 +1000 Subject: [PATCH] southbridge/amd/cimx/sb800: Uninitialized variables in config func Both 'SbSpiSpeedSupport' and 'UsbRxMode' are uninitiated upon return from a 'sb800_cimx_config()' call. Change-Id: I32237ff97fafc3e69627d427e54268dcb039e12c Found-by: Coverity Scan Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/6474 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi Reviewed-by: Stefan Reinauer --- src/southbridge/amd/cimx/sb800/cfg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c index 78aab799b7..91b6067055 100644 --- a/src/southbridge/amd/cimx/sb800/cfg.c +++ b/src/southbridge/amd/cimx/sb800/cfg.c @@ -122,10 +122,13 @@ void sb800_cimx_config(AMDSBCFG *sb_config) sb_config->SpreadSpectrum = SPREAD_SPECTRUM; sb_config->PciClks = PCI_CLOCK_CTRL; sb_config->HpetTimer = HPET_TIMER; + sb_config->SbSpiSpeedSupport = 1; /* USB */ sb_config->USBMODE.UsbModeReg = USB_CONFIG; sb_config->SbUsbPll = 0; + /* CG PLL multiplier for USB Rx 1.1 mode (0=disable, 1=enable) */ + sb_config->UsbRxMode = 1; /* SATA */ sb_config->SataClass = SATA_MODE;