sb,soc/amd: Move _PIC method to global scope
Fix regression with commitaa969e887a
ACPI: Move PICM declaration. While mentioned in the commit message there already, the default value for AMD boards changed from IOAPIC mode to PIC mode. ACPI 6.3 spec has this text regarding _PIC method: If the platform CPU architecture supports PIC mode and the method is never called, the platform runtime firmware must assume PIC mode. If MADT has IOAPIC entries, OS will want to change to APIC model. But the method _PIC was not in the global scope so it could not be called and therefore _PRT continued to report PIC model interrupt routing. Already fixed for soc/amd/picasso in commit839f668
. Change-Id: I7f3bb0d45946cec315694de1d540fea4d828348e Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50635 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
parent
aed4aca3fc
commit
6962b6ecd3
|
@ -103,7 +103,7 @@
|
|||
P3PR, 1,
|
||||
}
|
||||
|
||||
Method(_PIC, 0x01, NotSerialized)
|
||||
Method(\_PIC, 0x01, NotSerialized)
|
||||
{
|
||||
If (Arg0)
|
||||
{
|
||||
|
|
|
@ -103,7 +103,7 @@
|
|||
P3PR, 1,
|
||||
}
|
||||
|
||||
Method(_PIC, 0x01, NotSerialized)
|
||||
Method(\_PIC, 0x01, NotSerialized)
|
||||
{
|
||||
If (Arg0)
|
||||
{
|
||||
|
|
|
@ -132,7 +132,7 @@ Scope(\_SB) {
|
|||
P3PR, 1,
|
||||
}
|
||||
|
||||
Method(_PIC, 0x01, NotSerialized)
|
||||
Method(\_PIC, 0x01, NotSerialized)
|
||||
{
|
||||
If (Arg0)
|
||||
{
|
||||
|
|
|
@ -103,7 +103,7 @@
|
|||
P3PR, 1,
|
||||
}
|
||||
|
||||
Method(_PIC, 0x01, NotSerialized)
|
||||
Method(\_PIC, 0x01, NotSerialized)
|
||||
{
|
||||
If (Arg0)
|
||||
{
|
||||
|
|
Loading…
Reference in New Issue