GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd/amdmct/mct_ddr3: Fix S3 suspend overrunning the stack size limit 

Change-Id: Id7441dacef2e46e283d1fc99d5e5fa3f20e0d097
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: http://review.coreboot.org/11959
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Timothy Pearson 2015-05-31 18:46:40 -05:00 committed by Martin Roth
parent 502d457bf9
commit 69b11f9d40
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
View File

@ -539,10 +539,17 @@ int8_t save_mct_information_to_nvram(void)
struct spi_flash *flash; struct spi_flash *flash;
ssize_t s3nv_offset; ssize_t s3nv_offset;
struct amd_s3_persistent_data persistent_data; struct amd_s3_persistent_data *persistent_data;
/* Allocate temporary data structures */
persistent_data = malloc(sizeof(struct amd_s3_persistent_data));
if (!persistent_data) {
printk(BIOS_DEBUG, "Could not allocate S3 data structure in RAM\n");
return -1;
}
/* Obtain MCT configuration data */ /* Obtain MCT configuration data */
copy_mct_data_to_save_variable(&persistent_data); copy_mct_data_to_save_variable(persistent_data);
/* Obtain CBFS file offset */ /* Obtain CBFS file offset */
s3nv_offset = get_s3nv_file_offset(); s3nv_offset = get_s3nv_file_offset();
@ -572,7 +579,10 @@ int8_t save_mct_information_to_nvram(void)
/* Erase and write data structure */ /* Erase and write data structure */
flash->erase(flash, s3nv_offset, CONFIG_S3_DATA_SIZE); flash->erase(flash, s3nv_offset, CONFIG_S3_DATA_SIZE);
flash->write(flash, s3nv_offset, sizeof(struct amd_s3_persistent_data), &persistent_data); flash->write(flash, s3nv_offset, sizeof(struct amd_s3_persistent_data), persistent_data);
/* Deallocate temporary data structures */
free(persistent_data);
/* Tear down SPI flash access */ /* Tear down SPI flash access */
flash->spi->rw = SPI_WRITE_FLAG; flash->spi->rw = SPI_WRITE_FLAG;