mb/{intel/google}: Move CNVi ASL entry from static DSDT to dynamic SSDT generation

This changes uses drivers/intel/wifi chip for CNVi device to ensure that:
1. Correct device name shows in ACPI name space
2. Correct wake up shows in cat /proc/acpi/wakeup
3. Remove cnvi.asl from soc/intel/cannonlake

Change-Id: Ic81de2dce6045ced913766790a40ed19119f5118
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/29399
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Subrata Banik 2018-11-06 16:59:56 +05:30 committed by Patrick Georgi
parent 85376bfd9b
commit 69b18f0b68
12 changed files with 37 additions and 40 deletions

View File

@ -110,6 +110,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end
device pci 14.5 off end # SDCard device pci 14.5 off end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on device pci 15.1 on

View File

@ -110,6 +110,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end
device pci 14.5 off end # SDCard device pci 14.5 off end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on device pci 15.1 on

View File

@ -71,6 +71,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on end # I2C #1 device pci 15.1 on end # I2C #1

View File

@ -92,6 +92,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi
end
device pci 14.5 off end # SDCard device pci 14.5 off end # SDCard
device pci 15.0 on device pci 15.0 on
chip drivers/i2c/hid chip drivers/i2c/hid

View File

@ -95,7 +95,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on end # I2C #1 device pci 15.1 on end # I2C #1

View File

@ -79,7 +79,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on device pci 15.0 on
chip drivers/i2c/hid chip drivers/i2c/hid

View File

@ -111,7 +111,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on end # I2C 0 device pci 15.0 on end # I2C 0
device pci 15.1 on end # I2C #1 device pci 15.1 on end # I2C #1

View File

@ -95,7 +95,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on end # I2C #1 device pci 15.1 on end # I2C #1

View File

@ -86,7 +86,10 @@ chip soc/intel/cannonlake
device pci 12.6 off end # GSPI #2 device pci 12.6 off end # GSPI #2
device pci 14.0 on end # USB xHCI device pci 14.0 on end # USB xHCI
device pci 14.1 off end # USB xDCI (OTG) device pci 14.1 off end # USB xDCI (OTG)
chip drivers/intel/wifi
register "wake" = "PME_B0_EN_BIT"
device pci 14.3 on end # CNVi wifi device pci 14.3 on end # CNVi wifi
end
device pci 14.5 on end # SDCard device pci 14.5 on end # SDCard
device pci 15.0 on end # I2C #0 device pci 15.0 on end # I2C #0
device pci 15.1 on end # I2C #1 device pci 15.1 on end # I2C #1

View File

@ -1,32 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright (C) 2017 Intel Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <soc/pm.h>
/* CNVi Controller 0:14.3 */
Device (CNVI) {
Name(_ADR, 0x00140003)
Name (_S3D, 3) /* D3 supported in S3 */
Name (_S0W, 3) /* D3 can wake device in S0 */
Name (_S3W, 3) /* D3 can wake system from S3 */
Name (_PRW, Package() { PME_B0_EN_BIT, 3 })
Method (_STA, 0)
{
Return (0xF)
}
}

View File

@ -60,8 +60,5 @@
/* PCI _OSC */ /* PCI _OSC */
#include <soc/intel/common/acpi/pci_osc.asl> #include <soc/intel/common/acpi/pci_osc.asl>
/* CNVi */
#include "cnvi.asl"
/* GBe 0:1f.6 */ /* GBe 0:1f.6 */
#include "pch_glan.asl" #include "pch_glan.asl"

View File

@ -25,6 +25,7 @@
#include <soc/gpio.h> #include <soc/gpio.h>
#include <soc/pch.h> #include <soc/pch.h>
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
#include <soc/pm.h>
#include <soc/pmc.h> #include <soc/pmc.h>
#include <soc/serialio.h> #include <soc/serialio.h>
#include <soc/usb.h> #include <soc/usb.h>