GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

src/(device/lib/soc): Remove unused variables

Browse source 
When building grunt with flags set to detect variables that get a value but
then are unused, there are 5 instances that causes error (unused variable).
In most cases it's enough to simply remove the variable. Other instances,
is better to simply use the variables (one instance it's a return value, on
the other instance using the variables makes code more readable).

BUG=b:120260448
TEST=Build and boot grunt.

Change-Id: I0d00fb6a42db20afb34c76b9445a741a57096ead
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/c/29985
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Richard Spiegel 2018-11-30 10:53:40 -07:00 committed by Patrick Georgi
parent c3a27dffe9
commit 6a9e6cd89e
4 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/soc/amd/common/block/pi/def_callouts.c
View file

@ -116,10 +116,8 @@ AGESA_STATUS agesa_Reset(uint32_t Func, uintptr_t Data, void *ConfigPtr)
{ {
AGESA_STATUS Status; AGESA_STATUS Status;
uintptr_t ResetType; uintptr_t ResetType;
AMD_CONFIG_PARAMS *StdHeader;
ResetType = Data; ResetType = Data;
StdHeader = ConfigPtr;
/* /*
* This should perform the RESET based upon the ResetType, but coreboot * This should perform the RESET based upon the ResetType, but coreboot

1
src/soc/amd/stoneyridge/lpc.c
View file

@ -145,6 +145,7 @@ static void lpc_read_resources(struct device *dev)
/* Allocate ACPI NVS in CBMEM */ /* Allocate ACPI NVS in CBMEM */
gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(global_nvs_t)); gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(global_nvs_t));
printk(BIOS_DEBUG, "ACPI GNVS at %p\n", gnvs);
} }
static void lpc_set_resources(struct device *dev) static void lpc_set_resources(struct device *dev)

8
src/soc/amd/stoneyridge/northbridge.c
View file

@ -232,9 +232,9 @@ static unsigned long agesa_write_acpi_tables(struct device *device,
/* HEST */ /* HEST */
current = ALIGN(current, 8); current = ALIGN(current, 8);
hest = (acpi_hest_t *)current; hest = (acpi_hest_t *)current;
acpi_write_hest((void *)current, acpi_fill_hest); acpi_write_hest(hest, acpi_fill_hest);
acpi_add_table(rsdp, (void *)current); acpi_add_table(rsdp, (void *)current);
current += ((acpi_header_t *)current)->length; current += hest->header.length;
/* BERT */ /* BERT */
if (IS_ENABLED(CONFIG_ACPI_BERT) && bert_errors_present()) { if (IS_ENABLED(CONFIG_ACPI_BERT) && bert_errors_present()) {
@ -250,9 +250,9 @@ static unsigned long agesa_write_acpi_tables(struct device *device,
} else { } else {
current = ALIGN(current, 8); current = ALIGN(current, 8);
bert = (acpi_bert_t *)current; bert = (acpi_bert_t *)current;
acpi_write_bert((void *)current, (uintptr_t)rgn, size); acpi_write_bert(bert, (uintptr_t)rgn, size);
acpi_add_table(rsdp, (void *)current); acpi_add_table(rsdp, (void *)current);
current += ((acpi_header_t *)current)->length; current += bert->header.length;
} }
} }

3
src/soc/amd/stoneyridge/southbridge.c
View file

@ -217,13 +217,10 @@ uint16_t sb_wideio_size(int index)
*/ */
int sb_find_wideio_range(uint16_t start, uint16_t size) int sb_find_wideio_range(uint16_t start, uint16_t size)
{ {
uint32_t enable_register;
int i, index = WIDEIO_RANGE_ERROR; int i, index = WIDEIO_RANGE_ERROR;
uint16_t end, current_size, start_wideio, end_wideio; uint16_t end, current_size, start_wideio, end_wideio;
end = start + size; end = start + size;
enable_register = pci_read_config32(SOC_LPC_DEV,
LPC_IO_OR_MEM_DECODE_ENABLE);
for (i = 0; i < TOTAL_WIDEIO_PORTS; i++) { for (i = 0; i < TOTAL_WIDEIO_PORTS; i++) {
current_size = sb_wideio_size(i); current_size = sb_wideio_size(i);
if (current_size == 0) if (current_size == 0)