From 6af7261b2b2547a1e7dfe99c7e359e83d9f2314a Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Thu, 29 Jun 2023 20:25:32 +0200 Subject: [PATCH] acpi.c: Guard FACS generation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's not expected that non-x86 arch implement x86 style sleep states and resume. Signed-off-by: Arthur Heymans Change-Id: I7a1f36616e7f6adb021625e62e0fdf81864c7ac3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76178 Reviewed-by: Lean Sheng Tan Reviewed-by: Sridhar Siricilla Reviewed-by: Eric Lai Reviewed-by: Kyösti Mälkki Tested-by: build bot (Jenkins) --- src/acpi/acpi.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index dfa91e0386..0bb49f6ff7 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1499,13 +1499,14 @@ unsigned long write_acpi_tables(const unsigned long start) acpi_write_rsdt(rsdt, oem_id, oem_table_id); acpi_write_xsdt(xsdt, oem_id, oem_table_id); - current = ALIGN_UP(current, 64); - - printk(BIOS_DEBUG, "ACPI: * FACS\n"); - facs = (acpi_facs_t *)current; - current += sizeof(acpi_facs_t); - current = acpi_align_current(current); - acpi_create_facs(facs); + if (ENV_X86) { + printk(BIOS_DEBUG, "ACPI: * FACS\n"); + current = ALIGN_UP(current, 64); + facs = (acpi_facs_t *)current; + current += sizeof(acpi_facs_t); + current = acpi_align_current(current); + acpi_create_facs(facs); + } for (size_t i = 0; i < ARRAY_SIZE(tables); i++) { acpi_header_t *header = (acpi_header_t *)current;