From 6b324d99192d543fb29e00bb40935893c85b24a8 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 2 Aug 2023 18:48:25 +0200 Subject: [PATCH] soc/amd/common/data_fabric_helper: add comment about cfg_inst_acc_en Since all indirect data fabric register accesses will be non-broadcast accesses that target a specific data fabric instance, the cfg_inst_acc_en bit in the DF_FICAA_BIOS register will always be set since that makes the indirect access target only a specific data fabric instance. Signed-off-by: Felix Held Change-Id: I9aff01750c2c1e3506141b3ed293a980a64f8fac Reviewed-on: https://review.coreboot.org/c/coreboot/+/76885 Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger --- src/soc/amd/common/block/data_fabric/data_fabric_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c index fb4b26c049..1f0e2cf66b 100644 --- a/src/soc/amd/common/block/data_fabric/data_fabric_helper.c +++ b/src/soc/amd/common/block/data_fabric/data_fabric_helper.c @@ -13,7 +13,7 @@ static void data_fabric_set_indirect_address(uint8_t func, uint16_t reg, uint8_t instance_id) { - union df_ficaa ficaa = { .cfg_inst_acc_en = 1 }; + union df_ficaa ficaa = { .cfg_inst_acc_en = 1 }; /* target only specific instance */ /* convert register address to 32-bit register number */ ficaa.reg_num = reg >> 2; ficaa.func_num = func;