GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/kohaku: Add enable_delay_ms for wacom pen 

Add an enable reset delay to avoid messages like this in the
kernel:

i2c_hid i2c-WCOM50C1:00: failed to change power setting.

This gets rid of all the warnings except one on reboot/shutdown.
That last case likely isn't fixed because the sleep command is
being sent directly from i2c_hid_shutdown(), so no ACPI routines
get to run and provide the delay. Since the machine is going down
for shutdown/reboot anyway, fixing that last case is a lower
priority.

BUG=b:145094539
TEST=Run on kohaku, switch to guest mode and log out, no errors

Signed-off-by: Evan Green <evgreen@chromium.org>
Change-Id: I8fadf497dd09e5b95b1d74443fb0543d3555dbb8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39707
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Evan Green 2020-03-20 10:37:59 -07:00 committed by Furquan Shaikh
parent 8a6e036861
commit 6b7bbc2b78
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/hatch/variants/kohaku/overridetree.cb
View File

@ -207,6 +207,7 @@ chip soc/intel/cannonlake
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)"
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)"
register "generic.reset_delay_ms" = "100" register "generic.reset_delay_ms" = "100"
register "generic.enable_delay_ms" = "20"
register "generic.has_power_resource" = "1" register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x1" register "hid_desc_reg_offset" = "0x1"
device i2c 0x09 on end device i2c 0x09 on end