GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Delete PSPP TODO 

Because Mendocino doesn't support PCIe Gen4, PSPP on this platform does
not save any power, so leave it disabled.

BUG=273889287
TEST=None
BRANCH=skyrim

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I1a1c6692cd0a44469a35582042b92eeec31073fa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73826
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Martin Roth 2023-03-20 10:59:04 -06:00 committed by Felix Held
parent c5c7fa494b
commit 6bbf16d5d2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
View File

@ -79,7 +79,8 @@ chip soc/amd/mendocino
register "gpp_clk_config[2]" = "GPP_CLK_REQ"
register "gpp_clk_config[3]" = "GPP_CLK_OFF"
register "pspp_policy" = "DXIO_PSPP_DISABLED" # TODO: reenable when PSPP works
# PSPP doesn't save any power on this platform
register "pspp_policy" = "DXIO_PSPP_DISABLED"
register "s0ix_enable" = "true"