GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork/var/vilboz: Add enable acp_i2s_use_external_48mhz_osc flag 

Add enable acp_i2s_use_external_48mhz_osc flag and then
WWAN sku will use external clock source at next build.

BUG=b:174121847
BRANCH=zork
TEST=build vilboz and check MISC_CLK_CNTL1.

Signed-off-by: John Su <john_su@compal.corp-partner.google.com>
Change-Id: Ida747938373f648524b1e7f34bc69e372a69c4f9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48556
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
John Su 2020-12-11 14:31:24 +08:00 committed by Furquan Shaikh
parent e05298b1d2
commit 6c0aba2059
3 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/zork/variants/baseboard/helpers.c
View File

@ -46,6 +46,9 @@ enum {
/* Fan information */
FW_CONFIG_MASK_FAN = 0x3,
FW_CONFIG_SHIFT_FAN = 27,
/* WWAN presence */
FW_CONFIG_MASK_WWAN = 0x1,
FW_CONFIG_SHIFT_WWAN = 28,
};
static int get_fw_config(uint64_t *val)
@ -88,6 +91,11 @@ int variant_has_nvme(void)
return !!extract_field(FW_CONFIG_MASK_NVME, FW_CONFIG_SHIFT_NVME);
}
int variant_has_wwan(void)
{
return !!extract_field(FW_CONFIG_MASK_WWAN, FW_CONFIG_SHIFT_WWAN);
}
bool variant_uses_v3_schematics(void)
{
uint32_t board_version;

2
src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
View File

@ -63,6 +63,8 @@ const fsp_ddi_descriptor *baseboard_get_ddi_descriptors(size_t *num);
int variant_has_emmc(void);
/* Return 0 if non-existent, 1 if present. */
int variant_has_nvme(void);
/* Return 0 if non-existent, 1 if present. */
int variant_has_wwan(void);
/* Determine if booting in factory by using CROS_SKU_UNPROVISIONED. */
int boot_is_factory_unprovisioned(void);

10
src/mainboard/google/zork/variants/vilboz/variant.c
View File

@ -31,3 +31,13 @@ void variant_get_dxio_ddi_descriptors(const fsp_dxio_descriptor **dxio_descs,
*ddi_descs = &hdmi_ddi_descriptors[0];
*ddi_num = ARRAY_SIZE(hdmi_ddi_descriptors);
}
void variant_devtree_update(void)
{
struct soc_amd_picasso_config *soc_cfg;
soc_cfg = config_of_soc();
/* b:/174121847 Use external OSC to mitigate noise for WWAN sku. */
if (variant_has_wwan())
soc_cfg->acp_i2s_use_external_48mhz_osc = 1;
}