GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/icelake: Skip BIOS OpRom execution based on CONFIG_RUN_FSP_GOP 

This patch replaces BIOS OpRpm execution checks from CONFIG_INTEL_GMA_ADD_VBT
to CONFIG_RUN_FSP_GOP as adding VBT files doesn't mean GFX PEIM is going
to execute to initialize IGD.

Change-Id: Ic76529ba11f621f644d4472be6cbbc34682f00bf
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36532
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Subrata Banik 2019-11-01 14:09:09 +05:30
parent 522b7c0324
commit 6c1b18090d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/icelake/graphics.c
View File

@ -52,14 +52,14 @@ void graphics_soc_init(struct device *dev)
/* /*
* GFX PEIM module inside FSP binary is taking care of graphics * GFX PEIM module inside FSP binary is taking care of graphics
* initialization based on INTEL_GMA_ADD_VBT Kconfig * initialization based on RUN_FSP_GOP Kconfig
* option and input VBT file. Hence no need to load/execute legacy VGA * option and input VBT file. Hence no need to load/execute legacy VGA
* OpROM in order to initialize GFX. * OpROM in order to initialize GFX.
* *
* In case of non-FSP solution, SoC need to select VGA_ROM_RUN * In case of non-FSP solution, SoC need to select VGA_ROM_RUN
* Kconfig to perform GFX initialization through VGA OpRom. * Kconfig to perform GFX initialization through VGA OpRom.
*/ */
if (CONFIG(INTEL_GMA_ADD_VBT)) if (CONFIG(RUN_FSP_GOP))
return; return;
/* IGD needs to Bus Master */ /* IGD needs to Bus Master */