GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/it8772f: use pnp_ops.h for pnp register access 

Change-Id: I983249fb54b6fbccc4339c955cb5041848b21cf8
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35860
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Felix Held 2019-10-07 18:47:29 +02:00
parent 08abfa3814
commit 6c244bd4dd
2 changed files with 17 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/superio/ite/it8772f/early_init.c
View File

@ -21,26 +21,6 @@
/* NOTICE: This file is deprecated, use ite/common instead */ /* NOTICE: This file is deprecated, use ite/common instead */
/* RAMstage equiv */
/* u8 pnp_read_config(pnp_devfn_t dev, u8 reg) */
u8 it8772f_sio_read(pnp_devfn_t dev, u8 reg)
{
u16 port = dev >> 8;
outb(reg, port);
return inb(port + 1);
}
/* RAMstage equiv */
/* void pnp_write_config(pnp_devfn_t dev, u8 reg, u8 value) */
void it8772f_sio_write(pnp_devfn_t dev, u8 reg, u8 value)
{
u16 port = dev >> 8;
outb(reg, port);
outb(value, port + 1);
}
void it8772f_enter_conf(pnp_devfn_t dev) void it8772f_enter_conf(pnp_devfn_t dev)
{ {
u16 port = dev >> 8; u16 port = dev >> 8;
@ -53,15 +33,15 @@ void it8772f_enter_conf(pnp_devfn_t dev)
void it8772f_exit_conf(pnp_devfn_t dev) void it8772f_exit_conf(pnp_devfn_t dev)
{ {
it8772f_sio_write(dev, IT8772F_CONFIG_REG_CC, 0x02); pnp_write_config(dev, IT8772F_CONFIG_REG_CC, 0x02);
} }
/* Set AC resume to be up to the Southbridge */ /* Set AC resume to be up to the Southbridge */
void it8772f_ac_resume_southbridge(pnp_devfn_t dev) void it8772f_ac_resume_southbridge(pnp_devfn_t dev)
{ {
it8772f_enter_conf(dev); it8772f_enter_conf(dev);
it8772f_sio_write(dev, IT8772F_CONFIG_REG_LDN, IT8772F_EC); pnp_write_config(dev, IT8772F_CONFIG_REG_LDN, IT8772F_EC);
it8772f_sio_write(dev, 0xf4, 0x60); pnp_write_config(dev, 0xf4, 0x60);
it8772f_exit_conf(dev); it8772f_exit_conf(dev);
} }
@ -71,14 +51,14 @@ void it8772f_gpio_setup(pnp_devfn_t dev, int set, u8 select, u8 polarity,
{ {
set--; /* Set 1 is offset 0 */ set--; /* Set 1 is offset 0 */
it8772f_enter_conf(dev); it8772f_enter_conf(dev);
it8772f_sio_write(dev, IT8772F_CONFIG_REG_LDN, IT8772F_GPIO); pnp_write_config(dev, IT8772F_CONFIG_REG_LDN, IT8772F_GPIO);
if (set < 5) { if (set < 5) {
it8772f_sio_write(dev, GPIO_REG_SELECT(set), select); pnp_write_config(dev, GPIO_REG_SELECT(set), select);
it8772f_sio_write(dev, GPIO_REG_ENABLE(set), enable); pnp_write_config(dev, GPIO_REG_ENABLE(set), enable);
it8772f_sio_write(dev, GPIO_REG_POLARITY(set), polarity); pnp_write_config(dev, GPIO_REG_POLARITY(set), polarity);
} }
it8772f_sio_write(dev, GPIO_REG_OUTPUT(set), output); pnp_write_config(dev, GPIO_REG_OUTPUT(set), output);
it8772f_sio_write(dev, GPIO_REG_PULLUP(set), pullup); pnp_write_config(dev, GPIO_REG_PULLUP(set), pullup);
it8772f_exit_conf(dev); it8772f_exit_conf(dev);
} }
@ -88,15 +68,15 @@ void it8772f_gpio_led(pnp_devfn_t dev,int set, u8 select, u8 polarity, u8 pullup
{ {
set--; /* Set 1 is offset 0 */ set--; /* Set 1 is offset 0 */
it8772f_enter_conf(dev); it8772f_enter_conf(dev);
it8772f_sio_write(dev, IT8772F_CONFIG_REG_LDN, IT8772F_GPIO); pnp_write_config(dev, IT8772F_CONFIG_REG_LDN, IT8772F_GPIO);
if (set < 5) { if (set < 5) {
it8772f_sio_write(dev, IT8772F_GPIO_LED_BLINK1_PINMAP, led_pin_map); pnp_write_config(dev, IT8772F_GPIO_LED_BLINK1_PINMAP, led_pin_map);
it8772f_sio_write(dev, IT8772F_GPIO_LED_BLINK1_CONTROL, led_freq); pnp_write_config(dev, IT8772F_GPIO_LED_BLINK1_CONTROL, led_freq);
it8772f_sio_write(dev, GPIO_REG_SELECT(set), select); pnp_write_config(dev, GPIO_REG_SELECT(set), select);
it8772f_sio_write(dev, GPIO_REG_ENABLE(set), enable); pnp_write_config(dev, GPIO_REG_ENABLE(set), enable);
it8772f_sio_write(dev, GPIO_REG_POLARITY(set), polarity); pnp_write_config(dev, GPIO_REG_POLARITY(set), polarity);
} }
it8772f_sio_write(dev, GPIO_REG_OUTPUT(set), output); pnp_write_config(dev, GPIO_REG_OUTPUT(set), output);
it8772f_sio_write(dev, GPIO_REG_PULLUP(set), pullup); pnp_write_config(dev, GPIO_REG_PULLUP(set), pullup);
it8772f_exit_conf(dev); it8772f_exit_conf(dev);
} }

2
src/superio/ite/it8772f/it8772f.h
View File

@ -129,8 +129,6 @@ enum thermal_mode {
#include <device/pnp_type.h> #include <device/pnp_type.h>
#include <stdint.h> #include <stdint.h>
u8 it8772f_sio_read(pnp_devfn_t dev, u8 reg);
void it8772f_sio_write(pnp_devfn_t dev, u8 reg, u8 value);
void it8772f_ac_resume_southbridge(pnp_devfn_t dev); void it8772f_ac_resume_southbridge(pnp_devfn_t dev);
void it8772f_gpio_setup(pnp_devfn_t dev, int set, u8 select, u8 polarity, void it8772f_gpio_setup(pnp_devfn_t dev, int set, u8 select, u8 polarity,
u8 pullup, u8 output, u8 enable); u8 pullup, u8 output, u8 enable);