GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/pci: Fix validation of pointer 

Procedure write_pci_int_table() does not validates intr_data_ptr. It must
be validated together with picr_data_ptr and idx_name.

BUG=b:69868534
TEST=Build fake kahlee with intr_data_ptr not initialized, boot and see
error message. Than build correct kahlee and verify that error message
is gone.

Change-Id: I5ee9a362600dbd6325254d7431172501181b52b0
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/22934
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Richard Spiegel 2017-12-18 09:52:42 -07:00 committed by Marc Jones
parent ce90c0df41
commit 6c2ab060a2
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/amd/common/block/pci/amd_pci_util.c
View File

@ -59,11 +59,12 @@ void write_pci_int_table(void)
const struct irq_idx_name *idx_name;
idx_name = sb_get_apic_reg_association(&limit);
if (picr_data_ptr == NULL || idx_name == NULL) {
if (picr_data_ptr == NULL || intr_data_ptr == NULL ||
idx_name == NULL) {
printk(BIOS_ERR, "Warning: Can't write PCI_INTR 0xC00/0xC01"
" registers because\n"
"'mainboard_picr_data' or"
" irq_association' tables are NULL\n");
"'mainboard_picr_data' or 'mainboard_intr_data'"
" or 'irq_association'\ntables are NULL\n");
return;
}