From 6c8826de8fe5b13338d064ebbc50956b411d9cd9 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 17 Oct 2022 15:47:11 -0500 Subject: [PATCH] soc/intel/apollolake: Skip SMI lockdown on Apollolake Commit d9ef02ce (soc/intel/apollolake: Lock down Global SMI) breaks SMM/SMI on Apollolake (but not Geminilake), so guard it accordingly. TEST=build/boot google/reef, verify SMM/SMI/SMMSTORE functional. Change-Id: I00cbe046b61e6c342f7961670478d0ca8d365c2e Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/68549 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes Reviewed-by: Angel Pons --- src/soc/intel/apollolake/lockdown.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/soc/intel/apollolake/lockdown.c b/src/soc/intel/apollolake/lockdown.c index e11778b5dc..5de4bdd2c1 100644 --- a/src/soc/intel/apollolake/lockdown.c +++ b/src/soc/intel/apollolake/lockdown.c @@ -18,5 +18,6 @@ static void pmc_lock_smi(void) void soc_lockdown_config(int chipset_lockdown) { /* APL only supports CHIPSET_LOCKDOWN_COREBOOT */ - pmc_lock_smi(); + if (CONFIG(SOC_INTEL_GEMINILAKE)) + pmc_lock_smi(); }