GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elog: Fix duplicate event type 

The current elog implementation has two event types defined for 0xa7,
apparently the result of divergent coreboot trees on chromium where
some events were added to ARM systems but not upstreamed until later.

Fix this by moving ELOG_TYPE_THERM_TRIP to be 0xab, since the current
elog parsing code in chromium is using ELOG_TYPE_SLEEP for 0xa7.

BUG=b:35977516
TEST=check for proper "CPU Thermal Trip" event when investigating a
device that is unexpectedly powering down.

Change-Id: Idfa9b2322527803097f4f19f7930ccbdf2eccf35
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://review.coreboot.org/18579
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Duncan Laurie 2017-03-05 14:35:57 -08:00
parent da1d802ec4
commit 6cbd3980ab
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/elog.h
View File

@ -146,9 +146,6 @@ struct elog_event_data_me_extended {
/* EC Shutdown Reason */ /* EC Shutdown Reason */
#define ELOG_TYPE_EC_SHUTDOWN 0xa5 #define ELOG_TYPE_EC_SHUTDOWN 0xa5
/* CPU Thermal Trip */
#define ELOG_TYPE_THERM_TRIP 0xa7
/* ARM/generic versions of sleep/wake - These came from another firmware /* ARM/generic versions of sleep/wake - These came from another firmware
* apparently, but not all the firmware sources were updated so that the * apparently, but not all the firmware sources were updated so that the
* elog namespace was coherent. */ * elog namespace was coherent. */
@ -168,6 +165,9 @@ struct elog_event_mem_cache_update {
u8 status; u8 status;
} __attribute__ ((packed)); } __attribute__ ((packed));
/* CPU Thermal Trip */
#define ELOG_TYPE_THERM_TRIP 0xab
#if CONFIG_ELOG #if CONFIG_ELOG
/* Eventlog backing storage must be initialized before calling elog_init(). */ /* Eventlog backing storage must be initialized before calling elog_init(). */
extern int elog_init(void); extern int elog_init(void);