GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/meteorlake: Rename method is_eom to is_manufacturing_mode 

BUG=none
TEST=Build and boot to google/rex.

Excerpt from google/rex coreboot log:
[DEBUG]  ME: Manufacturing Mode          : YES

Signed-off-by: Kapil Porwal <kapilporwal@google.com>
Change-Id: I8d2de3365126ba618c987c412c4e9784012f9e0b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69698
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Kapil Porwal 2022-11-17 14:53:26 +05:30 committed by Martin L Roth
parent e8f86bc503
commit 6cecb0d963
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/soc/intel/meteorlake/me.c
View File

@ -76,16 +76,15 @@ union me_hfsts6 {
} __packed fields; } __packed fields;
}; };
static bool is_manufacturing_mode(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
/*
* Manufacturing mode is disabled if the descriptor is locked, fuses
* are programmed and manufacturing variables are locked.
* The function returns true if manufacturing mode is disabled otherwise false.
*/
static bool is_eom(union me_hfsts1 hfsts1, union me_hfsts6 hfsts6)
{ {
return (hfsts1.fields.mfg_mode == 0) && (hfsts6.fields.manuf_lock == 1) && /*
(hfsts6.fields.fpf_soc_lock == 1); * ME manufacturing mode is disabled if the descriptor is locked, fuses
* are programmed and manufacturing variables are locked.
*/
return !((hfsts1.fields.mfg_mode == 0) &&
(hfsts6.fields.fpf_soc_lock == 1) &&
(hfsts6.fields.manuf_lock == 1));
} }
static void dump_me_status(void *unused) static void dump_me_status(void *unused)
@ -96,6 +95,7 @@ static void dump_me_status(void *unused)
union me_hfsts4 hfsts4; union me_hfsts4 hfsts4;
union me_hfsts5 hfsts5; union me_hfsts5 hfsts5;
union me_hfsts6 hfsts6; union me_hfsts6 hfsts6;
bool manufacturing_mode;
if (!is_cse_enabled()) if (!is_cse_enabled())
return; return;
@ -114,8 +114,9 @@ static void dump_me_status(void *unused)
printk(BIOS_DEBUG, "ME: HFSTS5 : 0x%08X\n", hfsts5.data); printk(BIOS_DEBUG, "ME: HFSTS5 : 0x%08X\n", hfsts5.data);
printk(BIOS_DEBUG, "ME: HFSTS6 : 0x%08X\n", hfsts6.data); printk(BIOS_DEBUG, "ME: HFSTS6 : 0x%08X\n", hfsts6.data);
manufacturing_mode = is_manufacturing_mode(hfsts1, hfsts6);
printk(BIOS_DEBUG, "ME: Manufacturing Mode : %s\n", printk(BIOS_DEBUG, "ME: Manufacturing Mode : %s\n",
is_eom(hfsts1, hfsts6) ? "NO" : "YES"); manufacturing_mode ? "YES" : "NO");
/* /*
* The SPI Protection Mode bit reflects SPI descriptor * The SPI Protection Mode bit reflects SPI descriptor