GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Remove unused sleep GPIO table 

On Skyrim, there isn't a need for a sleep GPIO table. Remove the TODO
and filler table and function to reduce unnecessary function overhead.

BUG=None
BRANCH=Skyrim
TEST=Build Skyrim BIOS image.

Change-Id: Ia9d55a5e2295bb2e2c2957c4f5207362f616022c
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73852
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jon Murphy <jpmurphy@google.com>
This commit is contained in:
Karthikeyan Ramasubramanian 2023-03-20 12:24:25 -06:00 committed by Felix Held
parent 9c3407b99d
commit 6d2d8ea80a
3 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/mainboard/google/skyrim/variants/baseboard/gpio.c
View File

@ -168,11 +168,6 @@ static const struct soc_amd_gpio tpm_gpio_table[] = {
PAD_INT(GPIO_18, PULL_NONE, EDGE_LOW, STATUS_DELIVERY), PAD_INT(GPIO_18, PULL_NONE, EDGE_LOW, STATUS_DELIVERY),
}; };
/* GPIO configuration for sleep */
static const struct soc_amd_gpio sleep_gpio_table[] = {
/* TODO: Fill sleep gpio configuration */
};
/* GPIO configuration in bootblock */ /* GPIO configuration in bootblock */
static const struct soc_amd_gpio bootblock_gpio_table[] = { static const struct soc_amd_gpio bootblock_gpio_table[] = {
/* Enable WLAN */ /* Enable WLAN */
@ -252,12 +247,6 @@ __weak void variant_early_override_gpio_table(const struct soc_amd_gpio **gpio,
*gpio = NULL; *gpio = NULL;
} }
__weak void variant_sleep_gpio_table(const struct soc_amd_gpio **gpio, size_t *size)
{
*size = ARRAY_SIZE(sleep_gpio_table);
*gpio = sleep_gpio_table;
}
__weak void variant_espi_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) __weak void variant_espi_gpio_table(const struct soc_amd_gpio **gpio, size_t *size)
{ {
*size = ARRAY_SIZE(espi_gpio_table); *size = ARRAY_SIZE(espi_gpio_table);

3
src/mainboard/google/skyrim/variants/baseboard/include/baseboard/variants.h
View File

@ -29,9 +29,6 @@ void variant_early_gpio_table(const struct soc_amd_gpio **gpio, size_t *size);
/* This function allows variant to override any early GPIO init in early bootblock or psp. */ /* This function allows variant to override any early GPIO init in early bootblock or psp. */
void variant_early_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size); void variant_early_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size);
/* This function provides GPIO settings before entering sleep. */
void variant_sleep_gpio_table(const struct soc_amd_gpio **gpio, size_t *size);
/* This function provides GPIO settings for eSPI bus. */ /* This function provides GPIO settings for eSPI bus. */
void variant_espi_gpio_table(const struct soc_amd_gpio **gpio, size_t *size); void variant_espi_gpio_table(const struct soc_amd_gpio **gpio, size_t *size);

6
src/mainboard/google/skyrim/variants/baseboard/smihandler.c
View File

@ -11,13 +11,7 @@
void mainboard_smi_sleep(u8 slp_typ) void mainboard_smi_sleep(u8 slp_typ)
{ {
size_t num_gpios;
const struct soc_amd_gpio *gpios;
chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS);
variant_sleep_gpio_table(&gpios, &num_gpios);
gpio_configure_pads(gpios, num_gpios);
} }
int mainboard_smi_apmc(u8 apmc) int mainboard_smi_apmc(u8 apmc)