GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ATMEL 29C020 detection with flashrom. The JEDEC probe routine had 

a delay of 10 us after entering ID mode and this was insufficient for
the 29C020. The data sheet claims we have to wait 10 ms, but tests have
shown that 20 us suffice. Allow for variations in chip delays with a
factor of 2 safety margin.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2962 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Carl-Daniel Hailfinger 2007-11-13 14:56:54 +00:00
parent d591baa22f
commit 6d6146c377
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
util/flashrom/jedec.c
View File

@ -89,7 +89,11 @@ int probe_jedec(struct flashchip *flash)
*(volatile uint8_t *)(bios + 0x2AAA) = 0x55; *(volatile uint8_t *)(bios + 0x2AAA) = 0x55;
myusec_delay(10); myusec_delay(10);
*(volatile uint8_t *)(bios + 0x5555) = 0x90; *(volatile uint8_t *)(bios + 0x5555) = 0x90;
myusec_delay(10); /* Older chips may need up to 100 us to respond. The ATMEL 29C020
* needs 10 ms according to the data sheet, but it has been tested
* to work reliably with 20 us. Allow a factor of 2 safety margin.
*/
myusec_delay(40);
/* Read product ID */ /* Read product ID */
id1 = *(volatile uint8_t *)bios; id1 = *(volatile uint8_t *)bios;
@ -101,7 +105,7 @@ int probe_jedec(struct flashchip *flash)
*(volatile uint8_t *)(bios + 0x2AAA) = 0x55; *(volatile uint8_t *)(bios + 0x2AAA) = 0x55;
myusec_delay(10); myusec_delay(10);
*(volatile uint8_t *)(bios + 0x5555) = 0xF0; *(volatile uint8_t *)(bios + 0x5555) = 0xF0;
myusec_delay(10); myusec_delay(40);
printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2); printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, id1, id2);
if (id1 == flash->manufacture_id && id2 == flash->model_id) if (id1 == flash->manufacture_id && id2 == flash->model_id)