GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vboot: Change oprom checks to CONFIG_VBOOT, assert OPROM_MATTERS 

Skipping display init on normal-mode boot is a vboot feature, not
specific to Chrome OS. Fix the code in display_init_required() and
pci_dev_init() to check CONFIG_VBOOT rather than CONFIG_CHROMEOS now
that the two aren't always the same anymore.

Also add a check to guarantee at compile time that
CONFIG_VBOOT_OPROM_MATTERS is enabled on all platforms that make a check
to this function (when CONFIG_VBOOT is also enabled). The whole display
skipping mechanism is based on the oprom_needed NVRAM flag, and skipping
display init without enabling the option to tell vboot that it needs to
pay attention to that flag would make the whole thing not work right.

Change-Id: I5d6421509bdcdaa61b78015af3fa6241fe75bb7f
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32112
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Julius Werner 2019-03-28 13:33:55 -07:00 committed by Patrick Georgi
parent b197808852
commit 6d9c131061
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/device/pci_device.c
View File

@ -780,7 +780,7 @@ static int should_run_oprom(struct device *dev)
*/ */
should_run = display_init_required(); should_run = display_init_required();
if (!should_run && CONFIG(CHROMEOS)) if (!should_run && CONFIG(VBOOT))
should_run = vboot_wants_oprom(); should_run = vboot_wants_oprom();
if (!should_run) if (!should_run)

9
src/lib/bootmode.c
View File

@ -13,6 +13,7 @@
* GNU General Public License for more details. * GNU General Public License for more details.
*/ */
#include <assert.h>
#include <bootmode.h> #include <bootmode.h>
#include <vendorcode/google/chromeos/chromeos.h> #include <vendorcode/google/chromeos/chromeos.h>
@ -34,9 +35,13 @@ void gfx_set_init_done(int done)
int display_init_required(void) int display_init_required(void)
{ {
/* For Chrome OS always honor vboot_handoff_skip_display_init(). */ /* For vboot always honor vboot_handoff_skip_display_init(). */
if (CONFIG(CHROMEOS)) if (CONFIG(VBOOT)) {
/* Must always select OPROM_MATTERS when using this function. */
if (!CONFIG(VBOOT_OPROM_MATTERS))
dead_code();
return !vboot_handoff_skip_display_init(); return !vboot_handoff_skip_display_init();
}
/* By default always initialize display. */ /* By default always initialize display. */
return 1; return 1;