build system: strip quotes from CONFIG_CBFS_PREFIX in a single location
Instead of having to remember to strip the quotes everywhere so that string comparisons (of which there are a few) match up, do it right at the beginning. Fixes building the image with a .config where CONFIG_CBFS_PREFIX contains quotes. Change-Id: I4d63341cd9f0bc5e313883ef7b5ca6486190c124 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Reviewed-on: https://review.coreboot.org/12578 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
This commit is contained in:
parent
bd88fa0ef6
commit
6dc8570719
16
Makefile.inc
16
Makefile.inc
|
@ -15,6 +15,10 @@
|
|||
|
||||
GIT:=$(shell [ -d "$(top)/.git" ] && command -v git)
|
||||
|
||||
#######################################################################
|
||||
# normalize Kconfig variables in a central place
|
||||
CONFIG_CBFS_PREFIX:=$(call strip_quotes,$(CONFIG_CBFS_PREFIX))
|
||||
|
||||
#######################################################################
|
||||
# misleadingly named, this is the coreboot version
|
||||
export KERNELVERSION := $(strip $(if $(GIT),\
|
||||
|
@ -31,7 +35,7 @@ export MAINBOARDDIR
|
|||
## Final build results, which CBFSTOOL uses to create the final
|
||||
## rom image file, are placed under $(objcbfs).
|
||||
## These typically have suffixes .debug .elf .bin and .map
|
||||
export objcbfs := $(obj)/cbfs/$(call strip_quotes,$(CONFIG_CBFS_PREFIX))
|
||||
export objcbfs := $(obj)/cbfs/$(CONFIG_CBFS_PREFIX)
|
||||
|
||||
## Based on the active configuration, Makefile conditionally collects
|
||||
## the required assembly includes and saves them in a file.
|
||||
|
@ -189,10 +193,10 @@ endef
|
|||
# arg1: base file name
|
||||
# arg2: y or n for including in cbfs. defaults to y
|
||||
define asl_template
|
||||
$(call strip_quotes,$(CONFIG_CBFS_PREFIX))/$(1).aml-file = $(obj)/$(1).aml
|
||||
$(call strip_quotes,$(CONFIG_CBFS_PREFIX))/$(1).aml-type = raw
|
||||
$(call strip_quotes,$(CONFIG_CBFS_PREFIX))/$(1).aml-compression = none
|
||||
cbfs-files-$(if $(2),$(2),y) += $(call strip_quotes,$(CONFIG_CBFS_PREFIX))/$(1).aml
|
||||
$(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml
|
||||
$(CONFIG_CBFS_PREFIX)/$(1).aml-type = raw
|
||||
$(CONFIG_CBFS_PREFIX)/$(1).aml-compression = none
|
||||
cbfs-files-$(if $(2),$(2),y) += $(CONFIG_CBFS_PREFIX)/$(1).aml
|
||||
$(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h
|
||||
@printf " IASL $$(subst $(top)/,,$$(@))\n"
|
||||
$(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@
|
||||
|
@ -622,7 +626,7 @@ prebuilt-files = $(foreach file,$(cbfs-files), $(call extract_nth,1,$(file)))
|
|||
# Add all cbfs files to image of the form: CONFIG_CBFS_PREFIX/<filename>
|
||||
prebuild-files = \
|
||||
$(foreach file,$(cbfs-files), \
|
||||
$(if $(filter $(call strip_quotes, $(CONFIG_CBFS_PREFIX))/%,\
|
||||
$(if $(filter $(CONFIG_CBFS_PREFIX)/%,\
|
||||
$(call extract_nth,2,$(file))), \
|
||||
$(if $(call extract_nth,6,$(file)),$(cbfs-add-cmd) -a $(call extract_nth,6,$(file)) &&,\
|
||||
$(cbfs-add-cmd) $(if $(call extract_nth,5,$(file)),-b $(call extract_nth,5,$(file))) &&)))
|
||||
|
|
|
@ -168,7 +168,7 @@ $(BL31):
|
|||
|
||||
.PHONY: $(BL31)
|
||||
|
||||
BL31_CBFS := $(call strip_quotes,$(CONFIG_CBFS_PREFIX))/bl31
|
||||
BL31_CBFS := $(CONFIG_CBFS_PREFIX)/bl31
|
||||
$(BL31_CBFS)-file := $(BL31)
|
||||
$(BL31_CBFS)-type := stage
|
||||
$(BL31_CBFS)-compression := $(CBFS_COMPRESS_FLAG)
|
||||
|
@ -177,7 +177,7 @@ cbfs-files-y += $(BL31_CBFS)
|
|||
ifeq ($(CONFIG_ARM64_USE_SECURE_OS),y)
|
||||
|
||||
SECURE_OS_FILE := $(CONFIG_ARM64_SECURE_OS_FILE)
|
||||
SECURE_OS_FILE_CBFS := $(call strip_quotes,$(CONFIG_CBFS_PREFIX))/secure_os
|
||||
SECURE_OS_FILE_CBFS := $(CONFIG_CBFS_PREFIX)/secure_os
|
||||
$(SECURE_OS_FILE_CBFS)-file := $(SECURE_OS_FILE)
|
||||
$(SECURE_OS_FILE_CBFS)-type := stage
|
||||
cbfs-files-y += $(SECURE_OS_FILE_CBFS)
|
||||
|
|
Loading…
Reference in New Issue