GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vboot: fix invalid check for the returned value from spi_flash->write 

spi_flash->write returns non-zero on error and zero on success, not the
number of bytes written.

BUG=none
BRANCH=ToT
TEST=Booted storm. Verified successfully nvdata was saved.

Original-Change-Id: If50cc1a62a4f06398d1830cca60085b6f925fff3
Original-Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/229389
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Randall Spangler <rspangler@chromium.org>

(cherry picked from commit 1e8cdbdb07e99c3f72c35f76d68144f46107acd9)
Signed-off-by: Aaron Durbin <adurbin@chromium.org>

Change-Id: I216e97f734da8d4b52c2da8329f4143b7b0656cd
Reviewed-on: http://review.coreboot.org/9439
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Daisuke Nojiri 2014-11-12 14:01:23 -08:00 committed by Aaron Durbin
parent 627b3bd2b0
commit 6dc94c0682
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/vendorcode/google/chromeos/vbnv_flash.c
View File

@ -175,8 +175,7 @@ void save_vbnv(const uint8_t *vbnv_copy)
if (vbnv_flash_probe()) if (vbnv_flash_probe())
return; /* error */ return; /* error */
if (spi_flash->write(spi_flash, new_offset, if (spi_flash->write(spi_flash, new_offset, BLOB_SIZE, vbnv_copy)) {
BLOB_SIZE, vbnv_copy) != BLOB_SIZE) {
printk(BIOS_ERR, "failed to write nvdata\n"); printk(BIOS_ERR, "failed to write nvdata\n");
return; /* error */ return; /* error */
} }