GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp: Pass IIO_RESOURCE_INSTANCE as pointer 

IIO_RESOURCE_INSTANCE is a large struct, so it should be passed as a
constant pointer rather than making a copy.

Found-by: Coverity CID 1432759
Change-Id: Iebbb4d292f4d956e767bda28cbf20b0318586510
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46729
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jacob Garber 2020-10-24 16:23:45 -06:00 committed by Patrick Georgi
parent 5193312e1e
commit 6df3870012
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/intel/xeon_sp/nb_acpi.c
View File

@ -147,16 +147,16 @@ static unsigned long acpi_fill_slit(unsigned long current)
* in the context of ATSR subtable, it adds ATSR subtable when it is first called. * in the context of ATSR subtable, it adds ATSR subtable when it is first called.
*/ */
static unsigned long acpi_create_dmar_ds_pci_br_for_port(unsigned long current, static unsigned long acpi_create_dmar_ds_pci_br_for_port(unsigned long current,
int port, int stack, IIO_RESOURCE_INSTANCE iio_resource, uint32_t pcie_seg, int port, int stack, const IIO_RESOURCE_INSTANCE *iio_resource, uint32_t pcie_seg,
bool is_atsr, bool *first) bool is_atsr, bool *first)
{ {
if (soc_get_stack_for_port(port) != stack) if (soc_get_stack_for_port(port) != stack)
return 0; return 0;
const uint32_t bus = iio_resource.StackRes[stack].BusBase; const uint32_t bus = iio_resource->StackRes[stack].BusBase;
const uint32_t dev = iio_resource.PcieInfo.PortInfo[port].Device; const uint32_t dev = iio_resource->PcieInfo.PortInfo[port].Device;
const uint32_t func = iio_resource.PcieInfo.PortInfo[port].Function; const uint32_t func = iio_resource->PcieInfo.PortInfo[port].Function;
const uint32_t id = pci_mmio_read_config32(PCI_DEV(bus, dev, func), const uint32_t id = pci_mmio_read_config32(PCI_DEV(bus, dev, func),
PCI_VENDOR_ID); PCI_VENDOR_ID);
@ -253,7 +253,7 @@ static unsigned long acpi_create_drhd(unsigned long current, int socket,
hob->PlatformData.IIO_resource[socket]; hob->PlatformData.IIO_resource[socket];
for (int p = PORT_0; p < MAX_PORTS; ++p) for (int p = PORT_0; p < MAX_PORTS; ++p)
current += acpi_create_dmar_ds_pci_br_for_port(current, p, stack, current += acpi_create_dmar_ds_pci_br_for_port(current, p, stack,
iio_resource, pcie_seg, false, NULL); &iio_resource, pcie_seg, false, NULL);
// Add VMD // Add VMD
if (hob->PlatformData.VMDStackEnable[socket][stack] && if (hob->PlatformData.VMDStackEnable[socket][stack] &&
@ -317,7 +317,7 @@ static unsigned long acpi_create_atsr(unsigned long current, const IIO_UDS *hob)
if (socket == 0 && p == PORT_0) if (socket == 0 && p == PORT_0)
continue; continue;
current += acpi_create_dmar_ds_pci_br_for_port(current, p, current += acpi_create_dmar_ds_pci_br_for_port(current, p,
stack, iio_resource, pcie_seg, true, &first); stack, &iio_resource, pcie_seg, true, &first);
} }
} }
if (tmp != current) if (tmp != current)