From 6e3712f9e11582f98630d404ce48a538716d8fee Mon Sep 17 00:00:00 2001 From: Daniele Forsi Date: Sat, 26 Jul 2014 11:37:41 +0200 Subject: [PATCH] device/oprom/yabel/vbe.c: Fix memory leak Do not allocate memory if the bootsplash was not found. Found by Cppcheck 1.65. Fixes: [src/device/oprom/yabel/vbe.c:734]: (error) Memory leak: decdata Change-Id: Ie2283165c9d7650dce9baf9e892dd055d44dcce5 Signed-off-by: Daniele Forsi Reviewed-on: http://review.coreboot.org/6377 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- src/device/oprom/yabel/vbe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c index 6283bbb7f1..6354afe92e 100644 --- a/src/device/oprom/yabel/vbe.c +++ b/src/device/oprom/yabel/vbe.c @@ -719,7 +719,6 @@ void vbe_set_graphics(void) DEBUG_PRINTF_VBE("FRAMEBUFFER: 0x%p\n", framebuffer); struct jpeg_decdata *decdata; - decdata = malloc(sizeof(*decdata)); /* Switching Intel IGD to 1MB video memory will break this. Who * cares. */ @@ -736,6 +735,7 @@ void vbe_set_graphics(void) DEBUG_PRINTF_VBE("Splash at %p ...\n", jpeg); dump(jpeg, 64); + decdata = malloc(sizeof(*decdata)); int ret = 0; DEBUG_PRINTF_VBE("Decompressing boot splash screen...\n"); ret = jpeg_decode(jpeg, framebuffer, 1024, 768, 16, decdata);