GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/bootblock: Clear BSS section 

We are currently relying on the assumption that the amdcompress tool
will zero out the bss section. Instead of relying on this assumption,
lets explicitly clear it.

The implementation was copied from assembly_entry.S.

BUG=b:147042464
TEST=Cold boot trembyle and also s3 resume trembyle

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Ifb4f4cc6932dd4c3c92d4e7647569f9a0c69ea4c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42475
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Raul E Rangel 2020-06-17 11:10:58 -06:00 committed by Patrick Georgi
parent ec26428fcf
commit 6f1d35e72d
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/amd/picasso/bootblock/pre_c.S
View File

@ -23,6 +23,15 @@ bootblock_resume_entry:
bootblock_pre_c_entry: bootblock_pre_c_entry:
post_code(0xa0) post_code(0xa0)
/* Clear .bss section */
cld
xor %eax, %eax
movl $(_ebss), %ecx
movl $(_bss), %edi
sub %edi, %ecx
shrl $2, %ecx
rep stosl
movl $_eearlyram_stack, %esp movl $_eearlyram_stack, %esp
/* Align the stack and keep aligned for call to bootblock_c_entry() */ /* Align the stack and keep aligned for call to bootblock_c_entry() */