GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: Use device aliases for audio overrides 

Simplify audio overrides for dalboz baseboard-based variants by using
device aliases. This prevents duplicate ACPI devices from being
generated for the ChromeEC i2s tunnel (which causes Windows to BSOD
with an ACPI_BIOS_ERROR).

TEST=build/boot Win11 on google/zork (vilboz), dump ACPI tables
and verify only one EC tunnel device in SSDT.

Change-Id: I56aa2f761843aa269620f7e8c89ae9c0f205f349
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78509
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2023-10-24 15:30:28 -05:00 committed by Felix Held
parent 25765a0dce
commit 6f66ca82de
5 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/zork/variants/baseboard/dalboz/devicetree.cb
View File

@ -346,11 +346,11 @@ chip soc/amd/picasso
end end
device ref lpc_bridge on device ref lpc_bridge on
chip ec/google/chromeec chip ec/google/chromeec
device pnp 0c09.0 on device pnp 0c09.0 alias cros_ec on
chip ec/google/chromeec/i2c_tunnel chip ec/google/chromeec/i2c_tunnel
register "uid" = "1" register "uid" = "1"
register "remote_bus" = "8" register "remote_bus" = "8"
device generic 0.0 on device generic 0.0 alias cros_ec_i2c_8 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC5682"" register "hid" = ""10EC5682""
register "name" = ""RT58"" register "name" = ""RT58""

4
src/mainboard/google/zork/variants/dirinboz/overridetree.cb
View File

@ -150,9 +150,9 @@ chip soc/amd/picasso
end end
device ref lpc_bridge on device ref lpc_bridge on
chip ec/google/chromeec chip ec/google/chromeec
device pnp 0c09.0 on device ref cros_ec on
chip ec/google/chromeec/i2c_tunnel chip ec/google/chromeec/i2c_tunnel
device generic 0.0 on device ref cros_ec_i2c_8 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC5682"" register "hid" = ""10EC5682""
register "name" = ""RT58"" register "name" = ""RT58""

4
src/mainboard/google/zork/variants/gumboz/overridetree.cb
View File

@ -150,9 +150,9 @@ chip soc/amd/picasso
end end
device ref lpc_bridge on device ref lpc_bridge on
chip ec/google/chromeec chip ec/google/chromeec
device pnp 0c09.0 on device ref cros_ec on
chip ec/google/chromeec/i2c_tunnel chip ec/google/chromeec/i2c_tunnel
device generic 0.0 on device ref cros_ec_i2c_8 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC5682"" register "hid" = ""10EC5682""
register "name" = ""RT58"" register "name" = ""RT58""

4
src/mainboard/google/zork/variants/shuboz/overridetree.cb
View File

@ -95,9 +95,9 @@ chip soc/amd/picasso
end end
device ref lpc_bridge on device ref lpc_bridge on
chip ec/google/chromeec chip ec/google/chromeec
device pnp 0c09.0 on device ref cros_ec on
chip ec/google/chromeec/i2c_tunnel chip ec/google/chromeec/i2c_tunnel
device generic 0.0 on device ref cros_ec_i2c_8 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC5682"" register "hid" = ""10EC5682""
register "name" = ""RT58"" register "name" = ""RT58""

6
src/mainboard/google/zork/variants/vilboz/overridetree.cb
View File

@ -202,11 +202,9 @@ chip soc/amd/picasso
end end
device ref lpc_bridge on device ref lpc_bridge on
chip ec/google/chromeec chip ec/google/chromeec
device pnp 0c09.0 on device ref cros_ec on
chip ec/google/chromeec/i2c_tunnel chip ec/google/chromeec/i2c_tunnel
register "uid" = "1" device ref cros_ec_i2c_8 on
register "remote_bus" = "8"
device generic 0.0 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""10EC1015"" register "hid" = ""10EC1015""
register "desc" = ""RT1015 Tweeter Left Speaker Amp"" register "desc" = ""RT1015 Tweeter Left Speaker Amp""