GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/nehalem: Fix 'dead assignment' 

Dead increment spotted out using clang-tools.
Value stored to 'some_delay_3_halfcycles' is never read.

Change-Id: I8133f9e8786006bd278d281a132b6a2bd863a967
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36135
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes HAOUAS 2019-10-18 20:20:03 +02:00 committed by Patrick Georgi
parent 20994a763b
commit 6f7c955464
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/northbridge/intel/nehalem/raminit.c
View File

@ -820,12 +820,10 @@ static void compute_derived_timings(struct raminfo *info)
int some_delay_2_halfcycles_ceil; int some_delay_2_halfcycles_ceil;
int some_delay_2_halfcycles_floor; int some_delay_2_halfcycles_floor;
int some_delay_3_ps; int some_delay_3_ps;
int some_delay_3_halfcycles;
int some_delay_3_ps_rounded; int some_delay_3_ps_rounded;
int some_delay_1_cycle_ceil; int some_delay_1_cycle_ceil;
int some_delay_1_cycle_floor; int some_delay_1_cycle_floor;
some_delay_3_halfcycles = 0;
some_delay_3_ps_rounded = 0; some_delay_3_ps_rounded = 0;
extended_silicon_revision = info->silicon_revision; extended_silicon_revision = info->silicon_revision;
if (!info->silicon_revision) if (!info->silicon_revision)
@ -873,14 +871,13 @@ static void compute_derived_timings(struct raminfo *info)
some_delay_3_ps = some_delay_3_ps =
halfcycle_ps(info) - some_delay_2_ps % halfcycle_ps(info); halfcycle_ps(info) - some_delay_2_ps % halfcycle_ps(info);
if (info->revision_flag_1) { if (info->revision_flag_1) {
if (some_delay_3_ps < 150) if (some_delay_3_ps >= 150) {
some_delay_3_halfcycles = 0; const int some_delay_3_halfcycles =
else
some_delay_3_halfcycles =
(some_delay_3_ps << 6) / halfcycle_ps(info); (some_delay_3_ps << 6) / halfcycle_ps(info);
some_delay_3_ps_rounded = some_delay_3_ps_rounded =
halfcycle_ps(info) * some_delay_3_halfcycles >> 6; halfcycle_ps(info) * some_delay_3_halfcycles >> 6;
} }
}
some_delay_2_halfcycles_ceil = some_delay_2_halfcycles_ceil =
(some_delay_2_ps + halfcycle_ps(info) - 1) / halfcycle_ps(info) - (some_delay_2_ps + halfcycle_ps(info) - 1) / halfcycle_ps(info) -
2 * (some_delay_1_cycle_ceil - 1); 2 * (some_delay_1_cycle_ceil - 1);