GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/hatch: Remove pulls on NC pads 

There is no need to add internal termination (PU/PD) on the
not-connected pads. This change gets rid of the terminations on the NC
pads.

Change-Id: I3df538d7127e5ef75e6e6ff9db3524e26f0450ed
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33570
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Aamir Bohra <aamir.bohra@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Furquan Shaikh 2019-06-17 19:54:49 -07:00
parent 755a0131be
commit 6f7f39e96b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/hatch/variants/baseboard/gpio.c
View File

@ -138,9 +138,9 @@ static const struct pad_config gpio_table[] = {
/* C9 : UART_PCH_TX_DEBUG_RX */ /* C9 : UART_PCH_TX_DEBUG_RX */
PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1),
/* C10 : GPP_10 ==> GPP_C10_TP */ /* C10 : GPP_10 ==> GPP_C10_TP */
PAD_NC(GPP_C10, DN_20K), PAD_NC(GPP_C10, NONE),
/* C11 : GPP_11 ==> GPP_C11_TP */ /* C11 : GPP_11 ==> GPP_C11_TP */
PAD_NC(GPP_C11, DN_20K), PAD_NC(GPP_C11, NONE),
/* C12 : GPP_C12 ==> NC */ /* C12 : GPP_C12 ==> NC */
PAD_NC(GPP_C12, NONE), PAD_NC(GPP_C12, NONE),
/* C13 : EC_PCH_INT_L /* C13 : EC_PCH_INT_L
@ -343,7 +343,7 @@ static const struct pad_config gpio_table[] = {
/* G6 : SD_CLK */ /* G6 : SD_CLK */
PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1), PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1),
/* G7 : SD_WP => NC */ /* G7 : SD_WP => NC */
PAD_NC(GPP_G7, DN_20K), PAD_NC(GPP_G7, NONE),
/* /*
* H0 : HP_INT_L * H0 : HP_INT_L
*/ */