GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/siemens/mc_ehl2/devicetree.cb: Use RV3028 bus_speed instead of dummy i2c device 

Instead of creating a dummy I2C device in order to force Linux to
decrease the I2C bus speed, use the own 'bus_speed' field of RV3028
device config structure.

Linux should always set the bus speed to the speed of the slowest
device sitting on the bus. Hence the dummy device is not needed
here anymore.

BUG=none
TEST=See if the RV3028 RTC is visible and working (date/time can
be set/read) in Linux. At the time, a driver modification is needed
to add a match table for the "MCRY3028" ACPI HID. A proper kernel
patch is pending.

Change-Id: I6e269dc67d1fe2a6747fcf3bee224def7b553f08
Signed-off-by: Jan Samek <jan.samek@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69544
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
This commit is contained in:
Jan Samek 2022-11-14 13:47:25 +01:00 committed by Felix Held
parent 1560648197
commit 6f8fd5d397
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb
View File

@ -147,6 +147,7 @@ chip soc/intel/elkhartlake
device pci 15.1 on # I2C1 device pci 15.1 on # I2C1
# Enable external RTC chip # Enable external RTC chip
chip drivers/i2c/rv3028c7 chip drivers/i2c/rv3028c7
register "bus_speed" = "I2C_SPEED_STANDARD"
register "set_user_date" = "1" register "set_user_date" = "1"
register "user_year" = "04" register "user_year" = "04"
register "user_month" = "07" register "user_month" = "07"
@ -156,12 +157,6 @@ chip soc/intel/elkhartlake
register "cap_charge" = "CHARGE_OFF" register "cap_charge" = "CHARGE_OFF"
device i2c 0x52 on end # RTC RV3028-C7 device i2c 0x52 on end # RTC RV3028-C7
end end
# Add dummy I2C device to limit BUS speed to 100 kHz in OS
chip drivers/i2c/generic
register "hid" = ""PRP0001""
register "speed" = "I2C_SPEED_STANDARD"
device i2c 0x7f on end
end
end end
device pci 15.2 on # I2C2 device pci 15.2 on # I2C2
# Add dummy I2C device to limit BUS speed to 100 kHz in OS # Add dummy I2C device to limit BUS speed to 100 kHz in OS