From 7012a59fc71b130d1bad4a944beba552240ce31e Mon Sep 17 00:00:00 2001 From: Peter Lemenkov Date: Wed, 7 Nov 2018 19:04:26 +0100 Subject: [PATCH] mb/lenovo/*/dsdt: Move mainboard-specific defines out of ec.asl Most Lenovo mainboards define their own specific defines in dsdt.asl. Let's make it consistent across all Lenovo mainboards. Tested - builds fine. Change-Id: I03fbeb09b25e42af2dfbb220c0f726e6abb73673 Signed-off-by: Peter Lemenkov Reviewed-on: https://review.coreboot.org/c/29543 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph Reviewed-by: Paul Menzel --- src/mainboard/lenovo/t430/acpi/ec.asl | 6 ------ src/mainboard/lenovo/t430/dsdt.asl | 6 ++++++ src/mainboard/lenovo/x131e/acpi/ec.asl | 6 ------ src/mainboard/lenovo/x131e/dsdt.asl | 6 ++++++ 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mainboard/lenovo/t430/acpi/ec.asl b/src/mainboard/lenovo/t430/acpi/ec.asl index 3c7f89d89e..63d6a824bc 100644 --- a/src/mainboard/lenovo/t430/acpi/ec.asl +++ b/src/mainboard/lenovo/t430/acpi/ec.asl @@ -13,10 +13,4 @@ * GNU General Public License for more details. */ -#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB -#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB -#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 -#define EC_LENOVO_H8_ME_WORKAROUND 1 -#define THINKPAD_EC_GPE 17 - #include diff --git a/src/mainboard/lenovo/t430/dsdt.asl b/src/mainboard/lenovo/t430/dsdt.asl index 3cdebe9a4f..48e00767d1 100644 --- a/src/mainboard/lenovo/t430/dsdt.asl +++ b/src/mainboard/lenovo/t430/dsdt.asl @@ -15,6 +15,12 @@ * GNU General Public License for more details. */ +#define THINKPAD_EC_GPE 17 +#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 +#define EC_LENOVO_H8_ME_WORKAROUND 1 + #include DefinitionBlock( "dsdt.aml", diff --git a/src/mainboard/lenovo/x131e/acpi/ec.asl b/src/mainboard/lenovo/x131e/acpi/ec.asl index 02a9d2b66a..acbb778800 100644 --- a/src/mainboard/lenovo/x131e/acpi/ec.asl +++ b/src/mainboard/lenovo/x131e/acpi/ec.asl @@ -15,10 +15,4 @@ * GNU General Public License for more details. */ -#define THINKPAD_EC_GPE 22 -#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB -#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB -#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 -#define EC_LENOVO_H8_ME_WORKAROUND 1 - #include diff --git a/src/mainboard/lenovo/x131e/dsdt.asl b/src/mainboard/lenovo/x131e/dsdt.asl index d128c0d49b..3e5ede5a22 100644 --- a/src/mainboard/lenovo/x131e/dsdt.asl +++ b/src/mainboard/lenovo/x131e/dsdt.asl @@ -16,6 +16,12 @@ * GNU General Public License for more details. */ +#define THINKPAD_EC_GPE 22 +#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB +#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB +#define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 +#define EC_LENOVO_H8_ME_WORKAROUND 1 + #include DefinitionBlock( "dsdt.aml",