From 7066f1575ee34e11fd51e49f64316bdfcda0f7d4 Mon Sep 17 00:00:00 2001 From: Ian Feng Date: Thu, 5 May 2022 11:25:49 +0800 Subject: [PATCH] mb/google/skyrim: allow MKBP devices and disable TBMC device Enable MKBP (Matrix Keyboard Protocol) interface for all skyrim family to use for buttons and switches. Disable TBMC (Tablet Mode Switch device), as it is not needed anymore. BUG=b:230682161 TEST=manual test on Skyrim: Volume Up/Down and Power buttons, Tablet Mode switch Signed-off-by: Ian Feng Change-Id: I79ee2fdbb325491c9e3df5b9cff0c0c1181a7001 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64066 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Jon Murphy --- .../google/skyrim/variants/baseboard/include/baseboard/ec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/skyrim/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/skyrim/variants/baseboard/include/baseboard/ec.h index f10146dafc..ea6b93eef2 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/skyrim/variants/baseboard/include/baseboard/ec.h @@ -58,8 +58,8 @@ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GEVENT_5 /* AGPIO 11 -> GPE 5 */ -/* Enable Tablet switch */ -#define EC_ENABLE_TBMC_DEVICE +/* Enable MKBP for buttons and switches */ +#define EC_ENABLE_MKBP_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */