GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/prodrive/hermes: Use already-defined SMBus macros 

Drop chipset register definitions in mainboard code in favor of existing
definitions in a header. These definitions are not mainboard-specific.

Tested with BUILD_TIMELESS=1, Prodrive Hermes remains identical.

Change-Id: I29d6f35ec27bff43cf52ae697e905b6a7b48a8d1
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48805
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Angel Pons 2020-12-17 11:37:20 +01:00 committed by Hung-Te Lin
parent 3e4f4e0229
commit 707e03d8b9
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/prodrive/hermes/eeprom.c
View File

@ -3,6 +3,7 @@
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <console/console.h> #include <console/console.h>
#include <device/smbus_host.h> #include <device/smbus_host.h>
#include <soc/intel/common/block/smbus/smbuslib.h>
#include "variants/baseboard/include/eeprom.h" #include "variants/baseboard/include/eeprom.h"
/* /*
@ -32,7 +33,7 @@ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_off
int ret = 0; int ret = 0;
u32 smb_ctrl_reg = pci_read_config32(PCH_DEV_SMBUS, HOSTC); u32 smb_ctrl_reg = pci_read_config32(PCH_DEV_SMBUS, HOSTC);
pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN); pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | I2C_EN);
printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__, printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__,
read_offset, size); read_offset, size);

3
src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h
View File

@ -2,9 +2,6 @@
#include <soc/ramstage.h> #include <soc/ramstage.h>
#define HOSTC 0x40
#define SMBUS_IO_BASE 0xefa0
#define HOSTC_I2C_EN (1 << 2)
#define I2C_ADDR_EEPROM 0x57 #define I2C_ADDR_EEPROM 0x57
#if ENV_ROMSTAGE #if ENV_ROMSTAGE