From 70ca32e0ba565c567a5046c1e26d7c42d723a553 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Mon, 9 May 2016 08:14:45 +0200 Subject: [PATCH] siemens/mc_tcu3: Don't try to init unsupported panel type The LCD panel type is read using 4 GPIOs. Of these 16 possible combinations only 5 are supported right now. If the GPIO setting encodes an unsupported panel type, there will be no matching hwinfo.hex in cbfs. Therefore it makes no sense to try to initialize the DisplayPort-2-LVDS converter. Leave the function instead in this case. Change-Id: If8c67a3f5be762758d516c4939dd1de4ff1c8ba5 Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/14743 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Mario Scheithauer --- src/mainboard/siemens/mc_tcu3/lcd_panel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.c b/src/mainboard/siemens/mc_tcu3/lcd_panel.c index 1d1f3f96cc..f48bd56386 100644 --- a/src/mainboard/siemens/mc_tcu3/lcd_panel.c +++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.c @@ -67,6 +67,7 @@ int setup_lcd_panel(void) break; default: printk(BIOS_ERR, "LCD: No supported panel found.\n"); + return 1; break; }