From 70fb5cb514399db41a95849827c039b6c66ddbd7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Sun, 17 Oct 2021 17:43:53 +0200 Subject: [PATCH] kconfig_lint: put $inside_choice together right in the first place MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Instead of substituting the delimiter later, put $inside_choice together right in the first place. Signed-off-by: Michael Niewöhner Change-Id: Ia713510a683101c48c86a1c3722ebb1607a29288 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58400 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- util/lint/kconfig_lint | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 76dd78764c..9e2c207866 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -614,7 +614,7 @@ sub build_and_parse_kconfig_tree { $choice_symbol = $symbol; } $inside_config = ""; - $inside_choice = "$filename $line_no"; + $inside_choice = "$filename:$line_no"; $configs_inside_choice = 0; # Kconfig verifies that choice blocks have a prompt @@ -806,7 +806,7 @@ sub add_symbol { $symbols{$symbol}{choice} = 1; # remember the location of the choice - $symbols{$symbol}{choice_loc} = join(':', (split / /, $inside_choice)); + $symbols{$symbol}{choice_loc} = $inside_choice; } else { $symbols{$symbol}{choice} = 0;