From 7196be433efc05c8a74b2b82a7689d03d46f2d77 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 3 May 2019 20:07:56 +0530 Subject: [PATCH] soc/intel/skylake: Remove redundant mca_configure() in ramstage This patch removes redundant mca_configure() function call from ramstage to clear machine check exception. First time it's getting called from soc_core_init() function inside cpu.c file. TEST=Build and boot SKL/KBL/AML platform without any machine-check exception. Change-Id: I7e54fd07816c6317588ab6db06365937c4300ccd Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/32553 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Nick Vaccaro --- src/soc/intel/skylake/finalize.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index 5d7e1e0034..34738f28f1 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -20,7 +20,6 @@ #include #include #include -#include #include #include #include @@ -142,9 +141,6 @@ static void soc_finalize(void *unused) pch_finalize_script(dev); - printk(BIOS_DEBUG, "Clearing MCA.\n"); - mp_run_on_all_cpus(mca_configure, NULL, 17 * USECS_PER_SEC); - soc_lockdown(dev); printk(BIOS_DEBUG, "Finalizing SMM.\n");