From 71a7ba2e5d84198e63464287c8543d23c5d75e48 Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Thu, 10 Sep 2015 08:37:42 -0700 Subject: [PATCH] ifdtool: Enable warnings as errors, and fix any issues Change-Id: Id462a10c2affac54ec48a1cc2a5b2ca66112848e Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/11613 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- util/ifdtool/Makefile | 2 +- util/ifdtool/ifdtool.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index a234ded27b..02a02c45eb 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -22,7 +22,7 @@ PROGRAM = ifdtool CC = gcc INSTALL = /usr/bin/install PREFIX = /usr/local -CFLAGS = -O2 -g -Wall -W +CFLAGS = -O2 -g -Wall -W -Werror LDFLAGS = OBJS = ifdtool.o diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 214998c939..e6ed110c64 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -42,7 +42,7 @@ static const struct region_name region_names[MAX_REGIONS] = { { "Reserved", "res1" }, { "Reserved", "res2" }, { "Reserved", "res3" }, - { "EC" "ec" }, + { "EC", "ec" }, }; static fdbar_t *find_fd(char *image, int size) @@ -729,6 +729,9 @@ static void set_em100_mode(char *filename, char *image, int size) case IFD_VERSION_2: freq = SPI_FREQUENCY_17MHZ; break; + default: + freq = SPI_FREQUENCY_17MHZ; + break; } fcba->flcomp &= ~(1 << 30);