GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/cpu/x86: Update AMD detection 

AMD Picasso, and later, will not use CPU_AMD_AGESA or CPU_AMD_PI.
Those two symbols indicate an Arch2008 system.  Add SOC_AMD_COMMON
to cause cpu_is_amd() to return TRUE on Picasso.

This removes an error message of "Unknown CPU".

The patch also assumes AMD Family 10h and non-AGESA Family 15h
devices were seeing the "Unknown CPU" message.  No functionality
has been verified on these devices.

Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Change-Id: I3357606c37082f3587ff91924bf7a0e0f8af9625
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34146
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Marshall Dawson 2019-07-08 14:16:13 -05:00 committed by Patrick Georgi
parent 808440e6b2
commit 71c6c1725e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/arch/x86/include/arch/cpu.h
View File

@ -210,7 +210,8 @@ void smm_setup_structures(void *gnvs, void *tcg, void *smi1);
static inline bool cpu_is_amd(void) static inline bool cpu_is_amd(void)
{ {
return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI); return CONFIG(CPU_AMD_AGESA) || CONFIG(CPU_AMD_PI)
|| CONFIG(SOC_AMD_COMMON) || CONFIG(CPU_AMD_MODEL_10XXX);
} }
static inline bool cpu_is_intel(void) static inline bool cpu_is_intel(void)