GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

siemens/mc_apl1: Enable decoding for COM 3 on LPC 

It does not work to enable the LPC range in the function
mainboard_init() because the LPC bus driver closes the range during PCI
enumeration again. For this reason, enabling decoding of the address
range for COM 3 will be done at a later point in time -
mainboard_final().

Change-Id: I452bca4e430b1ea75e4a327591da84500491fe84
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/20295
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
This commit is contained in:
Mario Scheithauer 2017-06-21 12:42:10 +02:00 committed by Werner Zeh
parent db666a4d61
commit 71dacacb74
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/siemens/mc_apl1/mainboard.c
View File

@ -110,9 +110,6 @@ static void mainboard_init(void *chip_info)
pads = brd_gpio_table(&num);
gpio_configure_pads(pads, num);
/* Enable additional I/O decoding range on LPC for COM 3 */
lpc_open_pmio_window(0x3e8, 8);
}
static void mainboard_final(void *chip_info)
@ -128,6 +125,9 @@ static void mainboard_final(void *chip_info)
printk(BIOS_ERR, "LCD: Set up PTN with status 0x%x\n", status);
else
printk(BIOS_INFO, "LCD: Set up PTN was successful.\n");
/* Enable additional I/O decoding range on LPC for COM 3 */
lpc_open_pmio_window(0x3e8, 8);
}
struct chip_operations mainboard_ops = {