From 725a3d653360dfd441bfa8f4c7426b4c97e8dfe2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Thu, 5 Nov 2020 15:38:37 +0100 Subject: [PATCH] soc/intel/common/acpi: rename PEPD/LPI macros for clarification MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `ARG2` in the macro's names does not really provide any useful information. Drop it and add `LPI` to clarify the relation to only low-power idle states. Change-Id: I8d44c9e4974c7f34aa5c32ba00328725f536fda6 Signed-off-by: Michael Niewöhner Reviewed-on: https://review.coreboot.org/c/coreboot/+/47247 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/acpi/acpi/pep.asl | 28 ++++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/soc/intel/common/block/acpi/acpi/pep.asl b/src/soc/intel/common/block/acpi/acpi/pep.asl index 1bbeceff1d..2e822dbdfc 100644 --- a/src/soc/intel/common/block/acpi/acpi/pep.asl +++ b/src/soc/intel/common/block/acpi/acpi/pep.asl @@ -1,13 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#define PEPD_DSM_ARG2_ENUM_FUNCTIONS 0 -#define PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS 1 +#define PEPD_DSM_LPI_ENUM_FUNCTIONS 0 +#define PEPD_DSM_LPI_GET_DEVICE_CONSTRAINTS 1 -#define PEPD_DSM_ARG2_GET_CRASH_DUMP_DEV 2 -#define PEPD_DSM_ARG2_DISPLAY_OFF_NOTIFY 3 -#define PEPD_DSM_ARG2_DISPLAY_ON_NOTIFY 4 -#define PEPD_DSM_ARG2_S0IX_ENTRY 5 -#define PEPD_DSM_ARG2_S0IX_EXIT 6 +#define PEPD_DSM_LPI_GET_CRASH_DUMP_DEV 2 +#define PEPD_DSM_LPI_DISPLAY_OFF_NOTIFY 3 +#define PEPD_DSM_LPI_DISPLAY_ON_NOTIFY 4 +#define PEPD_DSM_LPI_S0IX_ENTRY 5 +#define PEPD_DSM_LPI_S0IX_EXIT 6 External(\_SB.MS0X, MethodObj) External(\_SB.PCI0.LPCB.EC0.S0IX, MethodObj) @@ -25,35 +25,35 @@ Device(PEPD) /* * Enum functions */ - If(Arg2 == PEPD_DSM_ARG2_ENUM_FUNCTIONS) { + If(Arg2 == PEPD_DSM_LPI_ENUM_FUNCTIONS) { Return(Buffer(One) {0x60}) } /* * Function 1 - Get Device Constraints */ - If(Arg2 == PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS) { + If(Arg2 == PEPD_DSM_LPI_GET_DEVICE_CONSTRAINTS) { Return(Package(5) {0, Ones, Ones, Ones, Ones}) } /* * Function 2 - Get Crash Dump Device */ - If(Arg2 == PEPD_DSM_ARG2_GET_CRASH_DUMP_DEV) { + If(Arg2 == PEPD_DSM_LPI_GET_CRASH_DUMP_DEV) { Return(Buffer(One) {0x0}) } /* * Function 3 - Display Off Notification */ - If(Arg2 == PEPD_DSM_ARG2_DISPLAY_OFF_NOTIFY) { + If(Arg2 == PEPD_DSM_LPI_DISPLAY_OFF_NOTIFY) { } /* * Function 4 - Display On Notification */ - If(Arg2 == PEPD_DSM_ARG2_DISPLAY_ON_NOTIFY) { + If(Arg2 == PEPD_DSM_LPI_DISPLAY_ON_NOTIFY) { } /* * Function 5 - Low Power S0 Entry Notification */ - If(Arg2 == PEPD_DSM_ARG2_S0IX_ENTRY) { + If(Arg2 == PEPD_DSM_LPI_S0IX_ENTRY) { /* Inform the EC */ If (CondRefOf (\_SB.PCI0.LPCB.EC0.S0IX)) { \_SB.PCI0.LPCB.EC0.S0IX(1) @@ -76,7 +76,7 @@ Device(PEPD) /* * Function 6 - Low Power S0 Exit Notification */ - If(Arg2 == PEPD_DSM_ARG2_S0IX_EXIT) { + If(Arg2 == PEPD_DSM_LPI_S0IX_EXIT) { /* Inform the EC */ If (CondRefOf (\_SB.PCI0.LPCB.EC0.S0IX)) { \_SB.PCI0.LPCB.EC0.S0IX(0)