GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove enable_cache() of 3 mainboards 

Because enable cache is added at the end of disable_cache_as_ram,
( http://review.coreboot.org/#/c/1662/2/src/cpu/amd/agesa/cache_as_ram.inc )
enable_cache() should be removed. The 3 mainboards are: amd parmer,
amd thatcher and tyan s8226

Change-Id: If870ca07d2e97b9e860a2e2315f551251c7a4ed2
Signed-off-by: Siyuan Wang <SiYuan.Wang@amd.com>
Signed-off-by: Siyuan Wang <wangsiyuanbuaa@gmail.com>
Reviewed-on: http://review.coreboot.org/1669
Reviewed-by: Marc Jones <marcj303@gmail.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Siyuan Wang 2012-11-02 18:14:30 +08:00 committed by Marc Jones
parent 75a26f875b
commit 7309709742
3 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/amd/parmer/romstage.c
View File

@ -27,7 +27,6 @@
#include <arch/romcc_io.h> #include <arch/romcc_io.h>
#include <arch/cpu.h> #include <arch/cpu.h>
#include <cpu/x86/lapic.h> #include <cpu/x86/lapic.h>
#include <cpu/x86/cache.h>
#include <console/console.h> #include <console/console.h>
#include <console/loglevel.h> #include <console/loglevel.h>
#include "agesawrapper.h" #include "agesawrapper.h"
@ -102,7 +101,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
} }
printk(BIOS_DEBUG, "Got past agesawrapper_amdinitenv\n"); printk(BIOS_DEBUG, "Got past agesawrapper_amdinitenv\n");
disable_cache_as_ram(); disable_cache_as_ram();
enable_cache();
#if CONFIG_HAVE_ACPI_RESUME #if CONFIG_HAVE_ACPI_RESUME
} else { /* S3 detect */ } else { /* S3 detect */
printk(BIOS_INFO, "S3 detected\n"); printk(BIOS_INFO, "S3 detected\n");

2
src/mainboard/amd/thatcher/romstage.c
View File

@ -27,7 +27,6 @@
#include <arch/romcc_io.h> #include <arch/romcc_io.h>
#include <arch/cpu.h> #include <arch/cpu.h>
#include <cpu/x86/lapic.h> #include <cpu/x86/lapic.h>
#include <cpu/x86/cache.h>
#include <console/console.h> #include <console/console.h>
#include <console/loglevel.h> #include <console/loglevel.h>
#include "agesawrapper.h" #include "agesawrapper.h"
@ -119,7 +118,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
} }
printk(BIOS_DEBUG, "Got past agesawrapper_amdinitenv\n"); printk(BIOS_DEBUG, "Got past agesawrapper_amdinitenv\n");
disable_cache_as_ram(); disable_cache_as_ram();
enable_cache();
#if CONFIG_HAVE_ACPI_RESUME #if CONFIG_HAVE_ACPI_RESUME
} else { /* S3 detect */ } else { /* S3 detect */
printk(BIOS_INFO, "S3 detected\n"); printk(BIOS_INFO, "S3 detected\n");

2
src/mainboard/tyan/s8226/romstage.c
View File

@ -35,7 +35,6 @@
#include "superio/winbond/w83627dhg/w83627dhg.h" #include "superio/winbond/w83627dhg/w83627dhg.h"
#include "src/drivers/pc80/i8254.c" #include "src/drivers/pc80/i8254.c"
#include "src/drivers/pc80/i8259.c" #include "src/drivers/pc80/i8259.c"
#include <cpu/x86/cache.h>
extern void disable_cache_as_ram(void); /* cache_as_ram.inc */ extern void disable_cache_as_ram(void); /* cache_as_ram.inc */
@ -133,7 +132,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
post_code(0x50); post_code(0x50);
print_debug("Disabling cache as ram "); print_debug("Disabling cache as ram ");
disable_cache_as_ram(); disable_cache_as_ram();
enable_cache();
print_debug("done\n"); print_debug("done\n");
post_code(0x51); post_code(0x51);