LGA1155 mainboards: Remove gfx.did and gfx.ndid

They are downright useless and result in ACPI errors. So, burn them.
Also, do a minor update to autoport's README about these values.

Change-Id: Idb5832cfd2e3043b8d70e13cbbe8bd94ad613120
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39184
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Angel Pons 2020-03-01 16:00:06 +01:00 committed by Patrick Georgi
parent 1c2313d339
commit 73704533d6
11 changed files with 1 additions and 22 deletions

View File

@ -15,9 +15,7 @@
# #
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.link_frequency_270_mhz" = "0" register "gfx.link_frequency_270_mhz" = "0"
register "gfx.ndid" = "3"
register "gfx.use_spread_spectrum_clock" = "0" register "gfx.use_spread_spectrum_clock" = "0"
register "gpu_cpu_backlight" = "0x00000000" register "gpu_cpu_backlight" = "0x00000000"
register "gpu_dp_b_hotplug" = "4" register "gpu_dp_b_hotplug" = "4"

View File

@ -14,8 +14,6 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.ndid" = "3"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -14,8 +14,6 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.ndid" = "3"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -1,7 +1,4 @@
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
# IGD Displays
register "gfx.ndid" = "3"
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
device cpu_cluster 0 on device cpu_cluster 0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax

View File

@ -14,8 +14,6 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.ndid" = "3"
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -14,8 +14,6 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.ndid" = "3"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -15,9 +15,7 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.link_frequency_270_mhz" = "0" register "gfx.link_frequency_270_mhz" = "0"
register "gfx.ndid" = "3"
register "gfx.use_spread_spectrum_clock" = "0" register "gfx.use_spread_spectrum_clock" = "0"
register "gpu_dp_b_hotplug" = "0" register "gpu_dp_b_hotplug" = "0"
register "gpu_dp_c_hotplug" = "0" register "gpu_dp_c_hotplug" = "0"

View File

@ -15,9 +15,7 @@
## ##
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.link_frequency_270_mhz" = "0" register "gfx.link_frequency_270_mhz" = "0"
register "gfx.ndid" = "3"
register "gfx.use_spread_spectrum_clock" = "0" register "gfx.use_spread_spectrum_clock" = "0"
register "gpu_dp_b_hotplug" = "0" register "gpu_dp_b_hotplug" = "0"
register "gpu_dp_c_hotplug" = "0" register "gpu_dp_c_hotplug" = "0"

View File

@ -1,7 +1,5 @@
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410 }"
register "gfx.link_frequency_270_mhz" = "0" register "gfx.link_frequency_270_mhz" = "0"
register "gfx.ndid" = "3"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -15,8 +15,6 @@
# #
chip northbridge/intel/sandybridge chip northbridge/intel/sandybridge
register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }"
register "gfx.ndid" = "3"
device cpu_cluster 0x0 on device cpu_cluster 0x0 on
chip cpu/intel/model_206ax chip cpu/intel/model_206ax
register "c1_acpower" = "1" register "c1_acpower" = "1"

View File

@ -342,7 +342,7 @@ on laptops (desktops have no "lid"!) but it makes sense to proofread it.
## `gfx.ndid` and `gfx.did` ## `gfx.ndid` and `gfx.did`
Those describe which video outputs are declared in ACPI tables. Those describe which video outputs are declared in ACPI tables.
Normally, there is no need to adjust these values, but if you miss some Normally, there is no need to have these values, but if you miss some
non-standard video output, you can declare it there. Bit 31 is set to non-standard video output, you can declare it there. Bit 31 is set to
indicate the presence of the output. Byte 1 is the type and byte 0 is indicate the presence of the output. Byte 1 is the type and byte 0 is
used for disambigution so that ID composed of byte 1 and 0 is unique. used for disambigution so that ID composed of byte 1 and 0 is unique.