GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/eve: Disable Deep S3 in AC mode 

In order to support a standard "docked" config disable Deep S3 when
connected to AC power.  This allows USB devices to wake the device
from suspend if it is externally powered, but still retains the
lower power state when running on battery.

BUG=b:36723679
BRANCH=none
TEST=manual testing on Eve for USB wake behavior:
1) when suspended on battery USB keyboard does not wake
2) when suspended while connected to AC a USB keyboard does wake
3) if suspended with AC, and then AC is removed, system does not
wake with USB keyboard
4) if suspended without AC, and then AC is added, system does not
wake with USB keyboard (it cannot get enabled without waking and
re-suspending)

Change-Id: I670e39d42cdb5b80612206da899be82ef3b2cbf2
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://review.coreboot.org/19240
Tested-by: build bot (Jenkins)
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Duncan Laurie 2017-04-10 21:07:06 -07:00
parent 654c8de9f1
commit 73ff0fbd2e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/eve/devicetree.cb
View File

@ -1,7 +1,7 @@
chip soc/intel/skylake chip soc/intel/skylake
# Enable deep Sx states # Enable deep Sx states
register "deep_s3_enable_ac" = "1" register "deep_s3_enable_ac" = "0"
register "deep_s3_enable_dc" = "1" register "deep_s3_enable_dc" = "1"
register "deep_s5_enable_ac" = "1" register "deep_s5_enable_ac" = "1"
register "deep_s5_enable_dc" = "1" register "deep_s5_enable_dc" = "1"