Remove nonsensical wrapper for function in

PS/2 keyboard API.

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5152 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Stefan Reinauer 2010-02-23 20:31:37 +00:00 committed by Patrick Georgi
parent 1c1d9a034a
commit 740b587baa
39 changed files with 39 additions and 49 deletions

View File

@ -5,7 +5,7 @@ struct pc_keyboard {
/* No initialization parameters for now */ /* No initialization parameters for now */
}; };
void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd); void pc_keyboard_init(struct pc_keyboard *keyboard);
void set_kbc_ps2_mode(void); void set_kbc_ps2_mode(void);
#endif /* PC80_KEYBOARD_H */ #endif /* PC80_KEYBOARD_H */

View File

@ -23,7 +23,7 @@ static void qemu_init(device_t dev)
/* This sneaked in here, because Qemu does not /* This sneaked in here, because Qemu does not
* emulate a SuperIO chip * emulate a SuperIO chip
*/ */
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
/* The PIRQ table is not working well for interrupt routing purposes. /* The PIRQ table is not working well for interrupt routing purposes.
* so we'll just set the IRQ directly. * so we'll just set the IRQ directly.

View File

@ -294,7 +294,7 @@ static void cx700_lpc_init(struct device *dev)
isa_dma_init(); isa_dma_init();
/* Initialize keyboard controller */ /* Initialize keyboard controller */
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
} }
static struct device_operations cx700_lpc_ops = { static struct device_operations cx700_lpc_ops = {

View File

@ -342,7 +342,7 @@ static void southbridge_init(struct device *dev)
setup_i8259(); // make sure interupt controller is configured before keyboard init setup_i8259(); // make sure interupt controller is configured before keyboard init
/* turn on keyboard and RTC, no need to visit this reg twice */ /* turn on keyboard and RTC, no need to visit this reg twice */
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
printk_debug printk_debug
("ps2 usb lid, you set who can wakeup system from s3 sleep\n"); ("ps2 usb lid, you set who can wakeup system from s3 sleep\n");
S3_ps2_kb_ms_wakeup(dev); S3_ps2_kb_ms_wakeup(dev);

View File

@ -159,7 +159,7 @@ static u8 send_keyboard(u8 command)
return regval; return regval;
} }
static void pc_keyboard_init(struct pc_keyboard *keyboard) void pc_keyboard_init(struct pc_keyboard *keyboard)
{ {
u8 regval; u8 regval;
printk_debug("Keyboard init...\n"); printk_debug("Keyboard init...\n");
@ -242,16 +242,6 @@ static void pc_keyboard_init(struct pc_keyboard *keyboard)
} }
} }
void init_pc_keyboard(unsigned port0, unsigned port1, struct pc_keyboard *kbd)
{
if ((port0 == 0x60) && (port1 == 0x64)) {
pc_keyboard_init(kbd);
} else {
printk_warning("Unsupported keyboard controller.\n");
}
}
/* /*
* Support PS/2 mode - oddball SIOs(KBC) need this setup * Support PS/2 mode - oddball SIOs(KBC) need this setup
* Not well documented. Google - 0xcb keyboard controller * Not well documented. Google - 0xcb keyboard controller

View File

@ -93,7 +93,7 @@ static void lpc_init(device_t dev)
int nmi_option; int nmi_option;
printk_debug("LPC_INIT -------->\n"); printk_debug("LPC_INIT -------->\n");
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
lpc_usb_legacy_init(dev); lpc_usb_legacy_init(dev);
lpc_common_init(dev); lpc_common_init(dev);

View File

@ -26,7 +26,7 @@ static void keyboard_on(void)
regval |= 0x0f; regval |= 0x0f;
pci_write_config8(lpc_dev, 0x51, regval); pci_write_config8(lpc_dev, 0x51, regval);
} }
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
} }
static void com_port_on(void) static void com_port_on(void)

View File

@ -26,7 +26,7 @@ static void keyboard_on(struct device *dev)
regval &= 0xfd; regval &= 0xfd;
pci_write_config8(dev, 0x51, regval); pci_write_config8(dev, 0x51, regval);
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
} }
void dump_south(device_t dev0) void dump_south(device_t dev0)

View File

@ -522,7 +522,7 @@ static void init_keyboard(struct device *dev)
{ {
u8 regval = pci_read_config8(dev, 0x51); u8 regval = pci_read_config8(dev, 0x51);
if (regval & 0x1) if (regval & 0x1)
init_pc_keyboard(0x60, 0x64, 0); pc_keyboard_init(0);
} }
static void southbridge_init_common(struct device *dev) static void southbridge_init_common(struct device *dev)

View File

@ -53,7 +53,7 @@ static void init(device_t dev)
case IT8671F_KBCK: case IT8671F_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case IT8671F_KBCM: /* TODO. */ case IT8671F_KBCM: /* TODO. */
break; break;

View File

@ -55,7 +55,7 @@ static void init(device_t dev)
case IT8673F_KBCK: case IT8673F_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case IT8673F_KBCM: /* TODO. */ case IT8673F_KBCM: /* TODO. */
break; break;

View File

@ -78,7 +78,7 @@ static void it8712f_init(device_t dev)
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
set_kbc_ps2_mode(); set_kbc_ps2_mode();
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case IT8712F_KBCM: /* TODO. */ case IT8712F_KBCM: /* TODO. */
break; break;

View File

@ -112,7 +112,7 @@ static void it8716f_init(device_t dev)
case IT8716F_KBCK: case IT8716F_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -55,7 +55,7 @@ static void init(device_t dev)
case IT8718F_KBCK: case IT8718F_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case IT8718F_KBCM: /* TODO. */ case IT8718F_KBCM: /* TODO. */
break; break;

View File

@ -54,7 +54,7 @@ static void init(device_t dev)
case PC8374_KBCK: case PC8374_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -48,7 +48,7 @@ static void init(device_t dev)
case PC87309_KBCK: case PC87309_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -60,7 +60,7 @@ static void init(device_t dev)
case PC87351_KBCK: case PC87351_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -54,7 +54,7 @@ static void init(device_t dev)
case PC87360_KBCK: case PC87360_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -54,7 +54,7 @@ static void init(device_t dev)
case PC87366_KBCK: case PC87366_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -55,7 +55,7 @@ static void init(device_t dev)
case PC87417_KBCK: case PC87417_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -52,7 +52,7 @@ static void init(device_t dev)
case PC87427_KBCK: case PC87427_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -55,7 +55,7 @@ static void init(device_t dev)
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case PC97307_FDC: case PC97307_FDC:

View File

@ -55,7 +55,7 @@ static void init(device_t dev)
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
#if 0 #if 0

View File

@ -41,7 +41,7 @@ static void m3885x_init(device_t dev)
printk_debug("Renesas M3885x: Initializing keyboard.\n"); printk_debug("Renesas M3885x: Initializing keyboard.\n");
set_kbc_ps2_mode(); set_kbc_ps2_mode();
init_pc_keyboard(0x60, 0x64, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
m3885_configure_multikey(); m3885_configure_multikey();
} }

View File

@ -53,7 +53,7 @@ static void init(device_t dev)
case FDC37M60X_KBCK: case FDC37M60X_KBCK:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case FDC37M60X_AUX: /* TODO. */ case FDC37M60X_AUX: /* TODO. */
break; break;

View File

@ -152,7 +152,7 @@ static void lpc47b272_init(device_t dev)
case LPC47B272_KBC: case LPC47B272_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -84,7 +84,7 @@ static void lpc47b397_init(device_t dev)
case LPC47B397_KBC: case LPC47B397_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -150,7 +150,7 @@ static void lpc47m10x_init(device_t dev)
case LPC47M10X2_KBC: case LPC47M10X2_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -119,7 +119,7 @@ static void lpc47m15x_init(device_t dev)
case LPC47M15X_KBC: case LPC47M15X_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(0x60, 0x64, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -164,7 +164,7 @@ static void lpc47n227_init(device_t dev)
case LPC47N227_KBDC: case LPC47N227_KBDC:
printk_debug("LPC47N227: Initializing keyboard.\n"); printk_debug("LPC47N227: Initializing keyboard.\n");
init_pc_keyboard(0x60, 0x64, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -232,7 +232,7 @@ static void smsc_init(device_t dev)
} else if (ld == logical_device_table[i].devs[LD_KBC]) { } else if (ld == logical_device_table[i].devs[LD_KBC]) {
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
} }
} }

View File

@ -59,7 +59,7 @@ static void w83627dhg_init(device_t dev)
case W83627DHG_KBC: case W83627DHG_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -125,7 +125,7 @@ static void w83627ehg_init(device_t dev)
case W83627EHG_KBC: case W83627EHG_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case W83627EHG_HWM: case W83627EHG_HWM:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);

View File

@ -133,7 +133,7 @@ static void w83627hf_init(device_t dev)
case W83627HF_KBC: case W83627HF_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
case W83627HF_HWM: case W83627HF_HWM:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);

View File

@ -66,7 +66,7 @@ static void w83627thf_init(device_t dev)
case W83627THF_KBC: case W83627THF_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -64,7 +64,7 @@ static void w83627thg_init(device_t dev)
case W83627THG_KBC: case W83627THG_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -113,7 +113,7 @@ static void w83627uhg_init(device_t dev)
case W83627UHG_KBC: case W83627UHG_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -61,7 +61,7 @@ static void w83977f_init(device_t dev)
case W83977F_KBC: case W83977F_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }

View File

@ -72,7 +72,7 @@ static void w83977tf_init(device_t dev)
case W83977TF_KBC: case W83977TF_KBC:
res0 = find_resource(dev, PNP_IDX_IO0); res0 = find_resource(dev, PNP_IDX_IO0);
res1 = find_resource(dev, PNP_IDX_IO1); res1 = find_resource(dev, PNP_IDX_IO1);
init_pc_keyboard(res0->base, res1->base, &conf->keyboard); pc_keyboard_init(&conf->keyboard);
break; break;
} }
} }