treewide,intel/skylake: Use boolean type for s0ix_enable dt option

Using the boolean type and the true/false macros give the reader a
better understanding about the option. Thus, use the bool type for the
attribute and use the macros for assignments.

Skylake mainboards which use that option were changed by the following
command ran from the root directory.

    socs="SOC_INTEL_(SKYLAKE|KABYLAKE|SKYLAKE_LGA1151_V2)" && \
    option="s0ix_enable" && \
    grep -Er "${socs}" src/mainboard | \
        cut -d ':' -f 1 | \
        awk -F '[/]' '{print $1"/"$2"/"$3"/"$4}' | \
        xargs grep -r "${option}" | \
        cut -d ':' -f 1 | \
        xargs sed -i'' -e "s/${option}\".*\=.*\"1\"/${option}\" \= true/g"

Change-Id: I372dfb65e6bbfc79c3f036ce34bc399875d5ff16
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75871
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jan Samek <jan.samek@siemens.com>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
Felix Singer 2023-06-16 01:33:25 +02:00 committed by Felix Singer
parent bafe55c36f
commit 743242b4aa
12 changed files with 13 additions and 12 deletions

View File

@ -311,7 +311,7 @@ chip soc/intel/skylake
register "gpe0_dw2" = "GPP_E" # 11:8 in pwrmbase+0120h register "gpe0_dw2" = "GPP_E" # 11:8 in pwrmbase+0120h
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" # 11:10 in A4h-A7h register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" # 11:10 in A4h-A7h
register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" # 5:4 in A4h-A7h register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" # 5:4 in A4h-A7h

View File

@ -62,7 +62,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0" register "SataSalpSupport" = "0"

View File

@ -37,7 +37,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# Disable Command TriState # Disable Command TriState
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"

View File

@ -28,7 +28,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0" register "SataSalpSupport" = "0"

View File

@ -28,7 +28,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0" register "SataSalpSupport" = "0"

View File

@ -28,7 +28,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0" register "SataSalpSupport" = "0"

View File

@ -30,7 +30,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# Disable Command TriState # Disable Command TriState
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"

View File

@ -37,7 +37,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# Disable Command TriState # Disable Command TriState
register "CmdTriStateDis" = "1" register "CmdTriStateDis" = "1"

View File

@ -28,7 +28,7 @@ chip soc/intel/skylake
register "dptf_enable" = "1" register "dptf_enable" = "1"
# Enable S0ix # Enable S0ix
register "s0ix_enable" = "1" register "s0ix_enable" = true
# FSP Configuration # FSP Configuration
register "SataSalpSupport" = "0" register "SataSalpSupport" = "0"

View File

@ -6,7 +6,7 @@ chip soc/intel/skylake
register "deep_s5_enable_ac" = "1" register "deep_s5_enable_ac" = "1"
register "deep_s5_enable_dc" = "1" register "deep_s5_enable_dc" = "1"
register "deep_sx_config" = "DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD" register "deep_sx_config" = "DSX_EN_WAKE_PIN | DSX_DIS_AC_PRESENT_PD"
register "s0ix_enable" = "1" register "s0ix_enable" = true
register "gpe0_dw0" = "GPP_B" register "gpe0_dw0" = "GPP_B"
register "gpe0_dw1" = "GPP_D" register "gpe0_dw1" = "GPP_D"

View File

@ -20,7 +20,7 @@ chip soc/intel/skylake
register "serirq_mode" = "SERIRQ_CONTINUOUS" register "serirq_mode" = "SERIRQ_CONTINUOUS"
# Enabling SLP_S0, SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch # Enabling SLP_S0, SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch
register "s0ix_enable" = "1" register "s0ix_enable" = true
register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS"
register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S"
register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S"

View File

@ -12,6 +12,7 @@
#include <intelblocks/gspi.h> #include <intelblocks/gspi.h>
#include <intelblocks/lpc_lib.h> #include <intelblocks/lpc_lib.h>
#include <intelblocks/power_limit.h> #include <intelblocks/power_limit.h>
#include <stdbool.h>
#include <stdint.h> #include <stdint.h>
#include <soc/gpe.h> #include <soc/gpe.h>
#include <soc/irq.h> #include <soc/irq.h>
@ -56,7 +57,7 @@ struct soc_intel_skylake_config {
uint32_t gen4_dec; uint32_t gen4_dec;
/* Enable S0iX support */ /* Enable S0iX support */
int s0ix_enable; bool s0ix_enable;
/* Enable DPTF support */ /* Enable DPTF support */
int dptf_enable; int dptf_enable;