From 7435e254d401e2b3bc78756f65e3d0f1b2ce61e2 Mon Sep 17 00:00:00 2001 From: Jakub Czapiga Date: Fri, 22 Jan 2021 15:47:11 +0100 Subject: [PATCH] acpi/acpigen.c: Remove unused and incorrect functions acpigen_write_name_zero() and acpigen_write_name_one() are not implemented correctly, and are not used anywhere. Drop them in favor of the more flexible acpigen_write_name_integer() function. Signed-off-by: Jakub Czapiga Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc Reviewed-on: https://review.coreboot.org/c/coreboot/+/49834 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie Reviewed-by: Lance Zhao Reviewed-by: Angel Pons --- src/acpi/acpigen.c | 12 ------------ src/include/acpi/acpigen.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 9a5543d5a4..5cc6a4edac 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -151,18 +151,6 @@ void acpigen_write_integer(uint64_t data) acpigen_write_qword(data); } -void acpigen_write_name_zero(const char *name) -{ - acpigen_write_name(name); - acpigen_write_one(); -} - -void acpigen_write_name_one(const char *name) -{ - acpigen_write_name(name); - acpigen_write_zero(); -} - void acpigen_write_name_byte(const char *name, uint8_t val) { acpigen_write_name(name); diff --git a/src/include/acpi/acpigen.h b/src/include/acpi/acpigen.h index 15af0192a3..7b1141c908 100644 --- a/src/include/acpi/acpigen.h +++ b/src/include/acpi/acpigen.h @@ -312,8 +312,6 @@ void acpigen_write_integer(uint64_t data); void acpigen_write_string(const char *string); void acpigen_write_name_unicode(const char *name, const char *string); void acpigen_write_name(const char *name); -void acpigen_write_name_zero(const char *name); -void acpigen_write_name_one(const char *name); void acpigen_write_name_string(const char *name, const char *string); void acpigen_write_name_dword(const char *name, uint32_t val); void acpigen_write_name_qword(const char *name, uint64_t val);