GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pnp_device: improve readability 

Add comments on the ops handling in pnp_enable_devices function and the
pnp_info struct.

Also remove the negation in the check if an LDN-specific override is used.
This patch doesn't change the logic though.

Change-Id: I3e80dbce1f29ee3e95e3b1d71c9b8479561d5c1a
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/27384
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Felix Held 2018-07-06 19:38:24 +02:00 committed by Martin Roth
parent f17a0df112
commit 745e58a5ee
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/device/pnp_device.c
View File

@ -386,10 +386,13 @@ void pnp_enable_devices(struct device *base_dev, struct device_operations *ops,
if (dev->ops)
continue;
if (info[i].ops == 0)
dev->ops = ops;
else
/* use LDN-specific ops override from corresponding pnp_info
entry if not NULL */
if (info[i].ops)
dev->ops = info[i].ops;
/* else use device ops */
else
dev->ops = ops;
get_resources(dev, &info[i]);
}

2
src/include/device/pnp.h
View File

@ -31,7 +31,7 @@ extern struct device_operations pnp_ops;
/* PNP helper operations */
struct pnp_info {
struct device_operations *ops;
struct device_operations *ops; /* LDN-specific ops override */
unsigned int function; /* Must be at least 16 bits (virtual LDNs)! */
unsigned int flags;
#define PNP_IO0 0x000001