GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/acpi: FBVDD_PWR_EN should be inverted on Agah 

The FBVDD_PWR_EN signal should be inverted in its control level
on Agah v.s. Hades.  The original change covered the Hades
implementation, but needs to be updated to invert for Agah.  This
change can be removed once we drop support for Agah.

BUG=b:280467267
TEST=built for Hades and Agah

Change-Id: I7f90c03b8d9b859004e5c124bf0a1f7b59921c3d
Signed-off-by: Tarun Tuli <taruntuli@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75530
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Tarun Tuli 2023-05-29 12:56:41 +00:00 committed by Felix Held
parent a3b46521fa
commit 74a986db9f
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/mainboard/google/brya/acpi/power.asl
View File

@ -128,8 +128,12 @@ Method (GC6I, 0, Serialized)
/* Deassert PG_GPU_ALLRAILS */
CTXS (GPIO_GPU_ALLRAILS_PG)
/* Deassert FBVDDQ Enable */
/* Ramp down FBVDD - TODO: Remove Agah when board is dropped */
#if CONFIG(BOARD_GOOGLE_AGAH)
STXS (GPIO_FBVDD_PWR_EN)
#else
CTXS (GPIO_FBVDD_PWR_EN)
#endif
/* Ramp down PEXVDD */
CTXS (GPIO_PEXVDD_PWR_EN)
@ -176,8 +180,13 @@ Method (GC6O, 0, Serialized)
STXS (GPIO_PEXVDD_PWR_EN)
GPPL (GPIO_PEXVDD_PG, 1, 4)
/* Assert FBVDDQ Enable */
STXS (GPIO_FBVDD_PWR_EN)
/* Ramp up FBVDD - TODO: Remove Agah when board is dropped */
#if CONFIG(BOARD_GOOGLE_AGAH)
CTXS (GPIO_FBVDD_PWR_EN)
#else
STXS (GPIO_FBVDD_PWR_EN)
#endif
/* Assert PG_GPU_ALLRAILS */
STXS (GPIO_GPU_ALLRAILS_PG)