From 74ed2a5d609165dd1279d91d69dc811b59404d2e Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Thu, 16 Jun 2022 13:35:40 -0600 Subject: [PATCH] mb/google/brya/var/agah: Remove variant_finalize The EEs and I misunderstood, and apparently the vfio-pci kernel driver will turn off the dGPU when it sees it is unused, so coreboot should leave the dGPU on so the kernel driver can save state before it shuts it down. TEST=Tested by ODM Signed-off-by: Tim Wawrzynczak Change-Id: I30b5dead7a5302f3385ddcaecfbf134c3bb68779 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65181 Reviewed-by: Robert Zieba Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- .../google/brya/variants/agah/variant.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/mainboard/google/brya/variants/agah/variant.c b/src/mainboard/google/brya/variants/agah/variant.c index b1ab79f05e..cc9389284c 100644 --- a/src/mainboard/google/brya/variants/agah/variant.c +++ b/src/mainboard/google/brya/variants/agah/variant.c @@ -138,23 +138,6 @@ void variant_init(void) dgpu_power_sequence_on(); } -void variant_finalize(void) -{ - if (acpi_is_wakeup_s3() || !gpu_powered_on) - return; - - /* - * Because the dGPU is used here in a way similar to "hybrid graphics" - * modes, it is powered down here. The DRIVERS_GFX_NVIDIA_SAVE_BARS - * option is selected for agah, so the BARs will be saved to ACPI memory - * during its finalize routine. Thus, it is powered down here, as the - * proper resources have already been allocated. - */ - dgpu_power_sequence_off(); - - printk(BIOS_INFO, "GPU power sequenced off.\n"); -} - /* Save PCI BARs to the ACPI copy of the "saved PCI config space" */ void variant_fill_ssdt(const struct device *unused) {