GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AGESA/PI: replace HUDSON_DISABLE_IMC with HUDSON_IMC_ENABLE 

Only a few boards are using IMC for the onboard fan control,
so regarding the availability of IMC selection it should be opt-in,
not opt-out. Also, select HUDSON_IMC_ENABLE for Gizmo 2
because Gizmo 2 could use IMC for the onboard fan control.

Signed-off-by: Mike Banon <mikebdp2@gmail.com>
Change-Id: I3590b13c3b155405d61e373daf1bd82ca8e3bd16
Reviewed-on: https://review.coreboot.org/c/30756
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Mike Banon 2019-01-09 02:37:07 +03:00 committed by Kyösti Mälkki
parent d06d5256e2
commit 7515cd0d04
7 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/asus/f2a85-m/Kconfig
View File

@ -30,7 +30,6 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_NUVOTON_NCT6779D if BOARD_ASUS_F2A85_M_PRO select SUPERIO_NUVOTON_NCT6779D if BOARD_ASUS_F2A85_M_PRO
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select GFXUMA select GFXUMA
select HUDSON_DISABLE_IMC
choice choice
prompt "DDR3 memory voltage" prompt "DDR3 memory voltage"

1
src/mainboard/gizmosphere/gizmo2/Kconfig
View File

@ -28,6 +28,7 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_4096 select BOARD_ROMSIZE_KB_4096
select GFXUMA select GFXUMA
select HUDSON_IMC_ENABLE
config MAINBOARD_DIR config MAINBOARD_DIR
string string

1
src/mainboard/msi/ms7721/Kconfig
View File

@ -30,7 +30,6 @@ config BOARD_SPECIFIC_OPTIONS
select SUPERIO_FINTEK_F71869AD select SUPERIO_FINTEK_F71869AD
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select GFXUMA select GFXUMA
select HUDSON_DISABLE_IMC
config MAINBOARD_DIR config MAINBOARD_DIR
string string

1
src/mainboard/pcengines/apu2/Kconfig
View File

@ -28,7 +28,6 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_MP_TABLE select HAVE_MP_TABLE
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select HUDSON_DISABLE_IMC
select USE_BLOBS select USE_BLOBS
select GENERIC_SPD_BIN select GENERIC_SPD_BIN
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM

7
src/southbridge/amd/agesa/hudson/Kconfig
View File

@ -55,8 +55,13 @@ config HUDSON_XHCI_FWM
help help
Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0 Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0
config HUDSON_IMC_ENABLE
bool
default n
config HUDSON_IMC_FWM config HUDSON_IMC_FWM
bool "Add imc firmware" bool "Add IMC firmware"
depends on HUDSON_IMC_ENABLE
default y if USE_BLOBS default y if USE_BLOBS
select SPI_FLASH_HAS_VOLATILE_GROUP if SPI_FLASH select SPI_FLASH_HAS_VOLATILE_GROUP if SPI_FLASH
help help

9
src/southbridge/amd/pi/hudson/Kconfig
View File

@ -22,9 +22,6 @@ config SOUTHBRIDGE_AMD_PI_AVALON
config SOUTHBRIDGE_AMD_PI_KERN config SOUTHBRIDGE_AMD_PI_KERN
bool bool
config HUDSON_DISABLE_IMC
bool
if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN
config SOUTHBRIDGE_SPECIFIC_OPTIONS # dummy config SOUTHBRIDGE_SPECIFIC_OPTIONS # dummy
@ -58,9 +55,13 @@ config HUDSON_XHCI_FWM
help help
Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0 Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0
config HUDSON_IMC_ENABLE
bool
default n
config HUDSON_IMC_FWM config HUDSON_IMC_FWM
bool "Add IMC firmware" bool "Add IMC firmware"
depends on !HUDSON_DISABLE_IMC depends on HUDSON_IMC_ENABLE
default y default y
help help
Add Hudson 2/3/4 IMC Firmware to support the onboard fan control Add Hudson 2/3/4 IMC Firmware to support the onboard fan control

1
src/vendorcode/amd/Kconfig
View File

@ -29,7 +29,6 @@ choice
config CPU_AMD_AGESA_BINARY_PI config CPU_AMD_AGESA_BINARY_PI
bool "binary PI" bool "binary PI"
select HUDSON_DISABLE_IMC if CPU_AMD_PI_00730F01 || CPU_AMD_PI_00630F01
help help
Use a binary PI package. Generally, these will be stored in the Use a binary PI package. Generally, these will be stored in the
"3rdparty/blobs" directory. For some processors, these must be obtained "3rdparty/blobs" directory. For some processors, these must be obtained