GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

soc/intel/common: Fix XHCI elog driver

Browse source 
Commit 56fcfb5 misused the PCH_DEVFNs passed to the XHCI elog driver, by
passing them directly to pci_s_read_config32. This is incorrect, as it
is the wrong PCI devfn encoding to pass to that function.

BUG=b:175996770
TEST=abuild

Change-Id: Id7c146c1f50ee64a725bd50f9f11a7f159013a2b
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48827
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Tim Wawrzynczak 2020-12-21 17:02:18 -07:00
parent 7a66ffb34a
commit 7567890110
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/soc/intel/common/block/xhci/elog.c
View file

@ -105,8 +105,9 @@ bool xhci_update_wake_event(const struct xhci_wake_info *wake_info,
for (i = 0; i < wake_info_count; ++i) {
/* Assumes BAR0 is MBAR */
mmio_base = pci_s_read_config32(wake_info[i].xhci_dev,
PCI_BASE_ADDRESS_0);
pci_devfn_t devfn = PCI_DEV(0, PCI_SLOT(wake_info[i].xhci_dev),
PCI_FUNC(wake_info[i].xhci_dev));
mmio_base = pci_s_read_config32(devfn, PCI_BASE_ADDRESS_0);
mmio_base &= ~PCI_BASE_ADDRESS_MEM_ATTR_MASK;
usb_info = soc_get_xhci_usb_info(wake_info[i].xhci_dev);